tree 0a3448c3a8c01869c3eb890bf149e0bac02b4a9a
parent ce4270691346d0df87116ab8a118877102fe3137
author Mike Klein <mtklein@google.com> 1566846058 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1566848225 +0000

more careful float -> int range checks

After upgrading my emscripten toolchain I got a warning that
INT_MAX can't be represented with a float, so the comparison

    if (fbits > INT_MAX)

may not be doing the comparison we want.  In fact, it was not...
we want to exclude any fbits value that's equal to (float)INT_MAX,
since that's actually greater than INT_MAX.

So add explicit casts here to let that new toolchain know we know
what we're doing, and count INT_MAX among the infinite.  INT_MIN
is a power of two so it's exactly representable as a float and that
comparison works as we were intending.

We do seem to hit these cases outside fuzzers, but I think only
when trying to fit curves that we'll fail to fit anyway.

Change-Id: I427d7c8e1d5a6a13328859646dd8d178f0e8f647
Reviewed-on: https://skia-review.googlesource.com/c/skcms/+/237211
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>