skia /
skcms /
4a77de48275bc91dbe8b8b822dd14e5f5ae45497 Revert "sketch single-source multi-target skcms_Transform()"
This reverts commit f7d520f5e6f54ee3c256911e8b20619b286a3f63.
Reason for revert: Clang/Win needs some work.
Original change's description:
> sketch single-source multi-target skcms_Transform()
>
> On x86-64 targets not already compiling globally with AVX2, we add in an
> extra AVX2 slice of the core of skcms_Transform() and run it if we
> detect CPU support at runtime. In exchange for the improved
> performance, we pay an extra 25 or 30K of code size.
>
> No signficant size or logic change in any other builds.
>
> I am ambivalent about whether skcms_Transform() should do its own CPU
> detection as written here, or take an argument with policy bits filled
> out by the caller, e.g.
>
> struct skcms_TransformPolicy {
> // If true, allow skcms_Transform() to use code targeting
> // Haswell or later (i.e. -march=haswell) processors,
> // namely the AVX2, F16C, and FMA instruction sets.
> bool hsw_ok;
> };
>
> Change-Id: Idfe3a28ad128bfb2fa48096cfc55d000255fbfbe
> Reviewed-on: https://skia-review.googlesource.com/117500
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Mike Klein <mtklein@chromium.org>
TBR=mtklein@chromium.org,brianosman@google.com
Change-Id: I059a7f459f11febdbb3760937b69c98f9d326ee2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/117820
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
5 files changed
