tree e2380a9580353284146c030f1297d90ab401c44a
parent 8efe18ec7b52a02139844ffe71438c00de13037e
author philter <hello@rive.app> 1785879761 +0000
committer philter <hello@rive.app> 1785879761 +0000

feat: Allow clipping to shapes with path effects (#13356) 0c254772d2
A ClippingShape built its clip from the source shape's raw composed geometry, so any path effect on the source's fill — trim, dash, or a scripted effect — was ignored. Clipping to a shape whose fill had been visibly modified used the unmodified path.

The clip now uses the aggregate of what the source shape's fills draw: each fill's post-effect path where it has an effect chain, the raw composed path otherwise, both where they're mixed.

Runtime. ClippingShape::addFillPaths reads each fill's lastEffectPath — the result the paint already resolved in its own update, so nothing is evaluated twice. buildDependencies adds an edge from effected fills to the clip so it sorts after them, and ShapePaint::invalidateRendering recurses so the clip rebuilds when an effect invalidates.

Editor. Effect resolution moves out of ShapePaint.render into a cached resolveEffectPath, which the clip reads during update and render reads after. This also fixes the chain re-running — and re-entering Lua — on every draw of every paint. Dirt is pushed to the composer's dependents explicitly: a Dart ShapePaint has no update pass to clear its own dirt, so addDirt's recursion stops propagating after the first call.

Strokes don't participate — their effect output is a centerline, meaningless filled.
An effect resolving to empty (trim at 0) clips to nothing rather than falling back to the raw path.
Fill visibility and opacity don't gate the contribution, matching how clipping already ignores paints.

Co-authored-by: Philip Chung <philterdesign@gmail.com>