| commit | 85a28fb8715e20e91ba986ae700f6b08a47438d7 | [log] [tgz] |
|---|---|---|
| author | luigi-rosso <hello@rive.app> | Tue Jul 09 19:55:37 2024 +0000 |
| committer | luigi-rosso <hello@rive.app> | Tue Jul 09 19:55:37 2024 +0000 |
| tree | b15efe9d2ade2dbc58ad761ead247fdcbadd632e | |
| parent | ca54937a1707639571552b82ddc140b503d23278 [diff] |
Fix jpeg and png decode overflows and error handling. Our png and jpeg decode methods suffer from overflow bugs caused when multiplying 32 bit dimensions that overflow 32 bits of storage. We fix this in two ways: - bump factors to size_t when multiplying to ensure large valid files can be decoded - check for overflow when passing row pointers for decoding or copying to ensure we don't access out of bounds memory Also includes some cleanup using unique ptr in png decoding. Also includes two tests with a bad png and a half-bad jpeg (half-bad as it can actually decode but provides incorrect/manipulated dimensions to attempt to cause overflow). Issue reported here: https://github.com/rive-app/rive-cpp/issues/373 Diffs= 93fb6eb83 Fix jpeg and png decode overflows and error handling. (#7535) Co-authored-by: Luigi Rosso <luigi-rosso@users.noreply.github.com>
Rive C++ is a runtime library for Rive, a real-time interactive design and animation tool.
The C++ runtime for Rive provides these runtime features:
We use premake5. The Rive dev team primarily works on MacOS. There is some work done by the community to also support Windows and Linux. PRs welcomed for specific platforms you wish to support! We encourage you to use premake as it's highly extensible and configurable for a variety of platforms.
In the rive-cpp directory, run build.sh to debug build and build.sh release for a release build.
If you've put the premake5 executable in the rive-cpp/build folder, you can run it with PATH=.:$PATH ./build.sh
Rive makes use of clang vector builtins, which are, as of 2022, still a work in progress. Please use clang and ensure you have the latest version.
cd skia/dependencies ./make_skia.sh // this will invoke get_skia.sh
To build viewer (plus you'll needed CMake installed)
./make_viewer_dependencies.sh
Uses the Catch2 testing framework.
cd dev ./test.sh
In the dev directory, run test.sh to compile and execute the tests.
(if you've installed premake5 in rive-cpp/build, you can run it with PATH=../../build:$PATH ./test.sh)
The tests live in rive/test. To add new tests, create a new xxx_test.cpp file here. The test harness will automatically pick up the new file.
There's a VSCode command provided to run tests from the Tasks: Run Task command palette.
rive-cpp uses clang-format, you can install it with brew on MacOS: brew install clang-format.
Note that if you‘re on MacOS you’ll want to install valgrind, which is somewhat complicated these days. This is the easiest solution (please PR a better one when it becomes available).
brew tap LouisBrunner/valgrind brew install --HEAD LouisBrunner/valgrind/valgrind
You can now run the all the tests through valgrind by running test.sh memory.
If you want to examine the generated assembly code per cpp file, install Disassembly Explorer in VSCode.
A disassemble task is provided to compile and preview the generated assembly. You can reach it via the Tasks: Run Task command palette or you can bind it to a shortcut by editing your VSCode keybindings.json:
[
{
"key": "cmd+d",
"command": "workbench.action.tasks.runTask",
"args": "disassemble"
}
]