| commit | 71ab91aaa053f9648b766f225a3ea25d9fe3159f | [log] [tgz] |
|---|---|---|
| author | mjtalbot <hello@rive.app> | Tue Feb 28 11:52:38 2023 +0000 |
| committer | mjtalbot <hello@rive.app> | Tue Feb 28 11:52:38 2023 +0000 |
| tree | 70c971f11b162288a7cdc797fa9d21a67d072042 | |
| parent | 8be08bbf3b1f0096af0679df8ba29bcbcc48f440 [diff] |
Fix negative speeds in state machines look commit by commit potentially, last couple of commits are running core generator & its quite a small change code wise, so it'd be good to get feedback on the actual change sooner rather than later there are at least a couple of changes in there that should make you question if this is a good idea so i expect some feedback. add to cpp: (i just got it working in the viewer, probably broke some things) - [x] negative time fix - [x] combine state speed to determine time for state - [x] no longer carry spilled time into new advances add test - [x] negative time fix to state machines - [x] negative combined time state fix to state machines - [ ] no longer carry spilled time into new advances @luigi-rosso i tried adding tests for this, but i was not really able to construct a state machine instance (with an animations, an animation state and the right transition) in tests I had to add a bunch of public methods all over the place, can you show me the way? probably not a blocker for merging this) apply changes to rive_flutter - [x] run script (ran both core generator and core generator runtime, the runtime one wanted to remove a load of comments so i didnt let those bits be committed. but still.. annoying) Diffs= bc6c6f467 Fix negative speeds in state machines (#4887)
C++ runtime for Rive. Provides these runtime features:
We use premake5. The Rive dev team primarily works on MacOS. There is some work done by the community to also support Windows and Linux. PRs welcomed for specific platforms you wish to support! We encourage you to use premake as it's highly extensible and configurable for a variety of platforms.
In the rive-cpp directory, run build.sh to debug build and build.sh release for a release build.
If you've put the premake5 executable in the rive-cpp/build folder, you can run it with PATH=.:$PATH ./build.sh
Rive makes use of clang vector builtins, which are, as of 2022, still a work in progress. Please use clang and ensure you have the latest version.
cd skia/dependencies ./make_skia.sh // this will invoke get_skia.sh
To build viewer (plus you'll needed CMake installed)
./make_viewer_dependencies.sh
Uses the Catch2 testing framework.
cd dev ./test.sh
In the dev directory, run test.sh to compile and execute the tests.
(if you've installed premake5 in rive-cpp/build, you can run it with PATH=../../build:$PATH ./test.sh)
The tests live in rive/test. To add new tests, create a new xxx_test.cpp file here. The test harness will automatically pick up the new file.
There's a VSCode command provided to run tests from the Tasks: Run Task command palette.
rive-cpp uses clang-format, you can install it with brew on MacOS: brew install clang-format.
Note that if you‘re on MacOS you’ll want to install valgrind, which is somewhat complicated these days. This is the easiest solution (please PR a better one when it becomes available).
brew tap LouisBrunner/valgrind brew install --HEAD LouisBrunner/valgrind/valgrind
You can now run the all the tests through valgrind by running test.sh memory.
If you want to examine the generated assembly code per cpp file, install Disassembly Explorer in VSCode.
A disassemble task is provided to compile and preview the generated assembly. You can reach it via the Tasks: Run Task command palette or you can bind it to a shortcut by editing your VSCode keybindings.json:
[
{
"key": "cmd+d",
"command": "workbench.action.tasks.runTask",
"args": "disassemble"
}
]