commit | 1eb7ac67d308d1cdf62a0e775ac593a4c74c8132 | [log] [tgz] |
---|---|---|
author | luigi-rosso <hello@rive.app> | Wed Apr 12 18:21:00 2023 +0000 |
committer | luigi-rosso <hello@rive.app> | Wed Apr 12 18:21:00 2023 +0000 |
tree | a1d7ddbe9a67b9f620f47dc613c034fe18d09d26 | |
parent | c1d7d98e89a21530f43b085f1e97e820802466d4 [diff] |
Fix for runtime crash with skins nested in solo nodes. Fixes a crash @HayesGordon caught when using the GameKit. Turns out it's a bug in the C++ runtime with loading of skins inside of nested solo nodes. We used to resolve the parent of a skin in the "onAddedClean" cycle as it assumed onDirty would only be called after load. Solos can now call that during the "onAddedClean" cycle. We can do the same logic "onAddedDirty" and then the onDirty calls will only happen after we've ascertained we have a valid skinnable parent, so the assumptions still hold. Diffs= 9266e0d30 Fix for runtime crash with skins nested in solo nodes. (#5109)
C++ runtime for Rive. Provides these runtime features:
We use premake5. The Rive dev team primarily works on MacOS. There is some work done by the community to also support Windows and Linux. PRs welcomed for specific platforms you wish to support! We encourage you to use premake as it's highly extensible and configurable for a variety of platforms.
In the rive-cpp
directory, run build.sh
to debug build and build.sh release
for a release build.
If you've put the premake5
executable in the rive-cpp/build
folder, you can run it with PATH=.:$PATH ./build.sh
Rive makes use of clang vector builtins, which are, as of 2022, still a work in progress. Please use clang and ensure you have the latest version.
cd skia/dependencies ./make_skia.sh // this will invoke get_skia.sh
To build viewer (plus you'll needed CMake installed)
./make_viewer_dependencies.sh
Uses the Catch2 testing framework.
cd dev ./test.sh
In the dev
directory, run test.sh
to compile and execute the tests.
(if you've installed premake5
in rive-cpp/build
, you can run it with PATH=../../build:$PATH ./test.sh
)
The tests live in rive/test
. To add new tests, create a new xxx_test.cpp
file here. The test harness will automatically pick up the new file.
There's a VSCode command provided to run tests
from the Tasks: Run Task command palette.
rive-cpp uses clang-format, you can install it with brew on MacOS: brew install clang-format
.
Note that if you‘re on MacOS you’ll want to install valgrind, which is somewhat complicated these days. This is the easiest solution (please PR a better one when it becomes available).
brew tap LouisBrunner/valgrind brew install --HEAD LouisBrunner/valgrind/valgrind
You can now run the all the tests through valgrind by running test.sh memory
.
If you want to examine the generated assembly code per cpp file, install Disassembly Explorer in VSCode.
A disassemble
task is provided to compile and preview the generated assembly. You can reach it via the Tasks: Run Task command palette or you can bind it to a shortcut by editing your VSCode keybindings.json:
[ { "key": "cmd+d", "command": "workbench.action.tasks.runTask", "args": "disassemble" } ]