commit e8ca89b55a9aefd76a9991c033a5359a0e5d07c1
author ajakubowicz-canva <ajakubowicz@canva.com> Tue May 27 21:51:34 2025 +1000
committer ajakubowicz-canva <ajakubowicz@canva.com> Tue May 27 21:51:34 2025 +1000
tree 081e8fd0a7f863297d6be9654ce6dc5954138f47
parent 1cb46ba18921ee88d36f1163eef2453b0d091533

use specific test name for diff view

sparse_strips/vello_sparse_tests/tests/renderer.rs

diff --git a/sparse_strips/vello_sparse_tests/tests/renderer.rs b/sparse_strips/vello_sparse_tests/tests/renderer.rs
index 690f3d9..64b0072 100644
--- a/sparse_strips/vello_sparse_tests/tests/renderer.rs
+++ b/sparse_strips/vello_sparse_tests/tests/renderer.rs
@@ -363,6 +363,7 @@
         texture_copy_buffer.unmap();
     }
 
+    // vello_hybrid WebGL renderer backend.
     #[cfg(all(target_arch = "wasm32", feature = "webgl"))]
     fn render_to_pixmap(&self, pixmap: &mut Pixmap, _: RenderMode) {
         use wasm_bindgen::JsCast;

sparse_strips/vello_sparse_tests/tests/util.rs

diff --git a/sparse_strips/vello_sparse_tests/tests/util.rs b/sparse_strips/vello_sparse_tests/tests/util.rs
index d94c776..26d4573 100644
--- a/sparse_strips/vello_sparse_tests/tests/util.rs
+++ b/sparse_strips/vello_sparse_tests/tests/util.rs
@@ -296,9 +296,10 @@
 #[cfg(target_arch = "wasm32")]
 pub(crate) fn check_ref(
     ctx: &impl Renderer,
-    // The name of the test.
-    test_name: &str,
-    _: &str,
+    _test_name: &str,
+    // The name of the specific instance of the test that is being run
+    // (e.g. test_gpu, test_cpu_u8, etc.)
+    specific_name: &str,
     // Tolerance for pixel differences.
     threshold: u8,
     // Must be `false` on `wasm32` as reference image cannot be written to filesystem.
@@ -316,13 +317,13 @@
 
     let diff_image = get_diff(&ref_image, &actual, threshold);
     if let Some(ref img) = diff_image {
-        append_diff_image_to_browser_document(test_name, img);
+        append_diff_image_to_browser_document(specific_name, img);
         panic!("test didn't match reference image. Scroll to bottom of browser to view diff.");
     }
 }
 
 #[cfg(target_arch = "wasm32")]
-fn append_diff_image_to_browser_document(test_name: &str, diff_image: &RgbaImage) {
+fn append_diff_image_to_browser_document(specific_name: &str, diff_image: &RgbaImage) {
     use wasm_bindgen::JsCast;
     use web_sys::js_sys::{Array, Uint8Array};
     use web_sys::{Blob, BlobPropertyBag, HtmlImageElement, Url, window};
@@ -344,7 +345,7 @@
         .unwrap();
 
     let title = document.create_element("h3").unwrap();
-    title.set_text_content(Some(&format!("Test Failed: {}", test_name)));
+    title.set_text_content(Some(&format!("Test Failed: {}", specific_name)));
     title
         .set_attribute("style", "color: red; margin-top: 0;")
         .unwrap();