commit b3a989d0dfeae6944f71459d31abf5e5cd89dc7e
author Sebastian Krzyszkowiak <dos@dosowisko.net> Tue Aug 10 13:08:27 2021 +0200
committer Sam Lantinga <slouken@libsdl.org> Tue Aug 10 08:34:07 2021 -0700
tree 9414037986b56b72199586b1f93d46adc6a4c764
parent de6ba40d9e0dd829ab4db0567251005df1c1cbd8

video: Fix false positives in driver name comparison

Without this change, driver names don't get matched correctly;
for example "x" can get matched with "x11" since it only checks
whether the string matches up to the length of the requested
driver name.

src/video/SDL_video.c

diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c
index ba15090..057dce0 100644
--- a/src/video/SDL_video.c
+++ b/src/video/SDL_video.c
@@ -505,7 +505,8 @@
                                                                      : SDL_strlen(driver_attempt);
 
             for (i = 0; bootstrap[i]; ++i) {
-                if (SDL_strncasecmp(bootstrap[i]->name, driver_attempt, driver_attempt_len) == 0) {
+                if ((driver_attempt_len == SDL_strlen(bootstrap[i]->name)) &&
+                    (SDL_strncasecmp(bootstrap[i]->name, driver_attempt, driver_attempt_len) == 0)) {
                     video = bootstrap[i]->create(index);
                     break;
                 }