tree 36d70f915c5e5167c2050f1ddbab87b0364c06ae
parent e7479a395086caebaf4e8d9d974858241c4442d7
author Sam Clegg <sbc@chromium.org> 1784847649 -0700
committer Sam Clegg <sbc@chromium.org> 1784847968 -0700

Support extra activated path via `activated_path_extra`

In newer versions of emscripten, executables are being moved into a
`bin` subdirectory instead of residing in the root directory. To enable
`emsdk` to add `bin` to `PATH` while maintaining backwards
compatibility with older emscripten releases, this change introduces an
optional `activated_path_extra` property on `Tool`.

When configuring `PATH` or checking environment activation,
`activated_path_extra` is checked and included in addition to the
primary `activated_path` if the directory exists on disk.

Alternatives considered:
- Delimited strings (e.g. semicolon or colon separated) in
  `activated_path`: Rejected because colon (`:`) conflicts with
  Windows drive letters (`C:\...`), and splitting string paths would
  require updating all call sites that expect `activated_path` to be a
  single directory (e.g., when writing `emscripten-version.txt`).
- JSON arrays in `activated_path`: While this avoids delimiter
  collisions on Windows, making `activated_path` polymorphic (either a
  string or list) would similarly complicate call sites requiring a
  single root directory.
- Hardcoded directory checking: Dynamically checking if a `bin`
  subdirectory exists in Python code was rejected to avoid excessive
  special-case tool checks in `emsdk.py`.