tree cc6a15723334f8a30fcfb6b96744528febd74920
parent 4a695be3485a6f3189cef079ec1928ee192c96de
author Amin Yahyaabadi <aminyahyaabadi74@gmail.com> 1604116635 -0500
committer GitHub <noreply@github.com> 1604116635 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfnOCbCRBK7hj4Ov3rIwAAdHIIADs/GdkC1QNkD3Kp7S588SvT
 gp+9Ojq28L/Ukj/KkKg5i+rchnmxaG2D9vZWTi5tYIG1nEJ6pSxFLIPYdr5ktW/W
 7XqC1sRoeoIK5zLtl5IAWsFSuxlpQqtROe6fDkH3wl/Zjmfd4rS6H926yHrooFCU
 jrIyrnuIKJllK6lP+zVkRSQhH+C4J7T8impicj+B0r+A9FY/jDSvkjUdhLtoG45s
 m3l3sdk2uoZP5SOXZdTB5RpFrOvoCW4Gx0mmqZMa/IKxJhavC4feI591JwvH1gFX
 7BdexYSzFb5vN2jFSmqhSfnfhmNJbbB2CrpnRzCBnF+4Q/VvjWINne7IQxMFa1s=
 =uzkm
 -----END PGP SIGNATURE-----
 

fix: emsdk swallows/overwrites parts of PATH (#642)

This PR has three changes: 

1) Fixing --permanent flag:
The previous algorithm looped over the values of PATH 4 times to check conditions while these conditions are the opposite of each other. Also, the result did not include all the parts in the whole_path. 

	I have combined these loops and fixed the algorithm, so no path is lost. Now using --permanent the PATH and Env variables are correctly updated.

2) Fixing --system flag:
Now, the system flag does not cause the PATH values to be overwritten/clobbered. The PATH/Env variables are correctly updated.

3) Fixing flagless flag:
When no flag is provided the value of process/shell is correctly updated and preserved.

This adds the tests for all the situations.

Fixes #634
Fixes #645