tree 8c9ac3ff52182e07030c7e02937a52eeaf586bb2
parent 891e73fa1146196b4cde7c7873ca1a352fc40a58
author Gabriel Peal <gpeal@users.noreply.github.com> 1559249841 -0700
committer GitHub <noreply@github.com> 1559249841 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJc8EOxCRBK7hj4Ov3rIwAAdHIIAHbbaw/X2S5atkR/DDGfR4BG
 uAnoKYUKPZfN10EIpWl0EbzjblHwVKCEZJP+OoW78BUYJnRl/3GMNB3LD1RE0SsJ
 fvakWFBxjgJo2UQgOicHYR+1XvTAGRagSvokbiI9geLqGgMDYl9RSutEVQmbw3Jx
 r8znTE6XO5sqOGc+mN3MztnhOfLwt6FZ3DCsrDdVNnn5JI3aRrHXuK4DoS5aqRzN
 EYeaCEtyDKHzMugPVKuJ+BqkirXOdo8NRhNbGx8sD7OpjjKY7R3TeWk2I6lpEAHw
 ana6ZG6jpiJuab7mfkl17oRr/Z/lffrB3VP6kUoVb0Ni5XN21jgIFA3hGLDIqmc=
 =ZSwr
 -----END PGP SIGNATURE-----
 

Use moshi implementation for json parsing (#1234)

There's a dependency on OKIO & 8 classes copied from Moshi. Need to figure out best path forward. Ideally we don't depend on all of Moshi but still get the gains of the new JsonReader & Options api. This should fix the random Android 8 crashes.

Performance
I ran the snapshot tests with ~1800 animations and summed up just the parsing time. The old parsing code took 13,145ms and 13,645ms on each test run (avg 13,395ms). The new code took 12,858ms each time. There aren't enough trials to deduce statistical differences but if these numbers hold, the new code parses ~5% faster.
It does reduce memory allocations during parsing which may contribute to the performance improvement.

I'm leaning on merging this to hopefully fix #667