commit 4c805889968bfa2eba6c87cd99a093aa5261beb3
author Gabriel Peal <gpeal@users.noreply.github.com> Sun Oct 29 21:19:13 2023 -0700
committer GitHub <noreply@github.com> Sun Oct 29 21:19:13 2023 -0700
tree ec6e421855a8ab6b9d5f4fd8c24177728060c10e
parent f20394bb686d803d5ff57ddfda9a027eac314772

Fix a NPE in ColorKeyframeAnimation (#2407)

It is not clear to me why or how this would happen. endFrame is technically nullable because of the order that parsing happens but it should be non-null by the time parsing finishes. This should be safe enough to add to fix this NPE though.

Fixes #2361

lottie/src/main/java/com/airbnb/lottie/animation/keyframe/ColorKeyframeAnimation.java

diff --git a/lottie/src/main/java/com/airbnb/lottie/animation/keyframe/ColorKeyframeAnimation.java b/lottie/src/main/java/com/airbnb/lottie/animation/keyframe/ColorKeyframeAnimation.java
index 3c83b26..93bf944 100644
--- a/lottie/src/main/java/com/airbnb/lottie/animation/keyframe/ColorKeyframeAnimation.java
+++ b/lottie/src/main/java/com/airbnb/lottie/animation/keyframe/ColorKeyframeAnimation.java
@@ -25,7 +25,10 @@
       throw new IllegalStateException("Missing values for keyframe.");
     }
 
-    if (valueCallback != null) {
+    // keyframe.endFrame should not be null under normal operation.
+    // It is not clear why this would be null and when it does, it seems to be extremely rare.
+    // https://github.com/airbnb/lottie-android/issues/2361
+    if (valueCallback != null && keyframe.endFrame != null) {
       //noinspection ConstantConditions
       Integer value = valueCallback.getValueInternal(keyframe.startFrame, keyframe.endFrame, keyframe.startValue,
           keyframe.endValue, keyframeProgress, getLinearCurrentKeyframeProgress(), getProgress());