)]}' { "commit": "036224ff7116c870eefe20397f9caf17ff4f8b23", "tree": "c91753110d636c0ec6fd42c36f8295925da6bd30", "parents": [ "cbd3d55ba78c11ec550792e8ca64ed51bb60112d" ], "author": { "name": "Gabriel Peal", "email": "gpeal@users.noreply.github.com", "time": "Sun Sep 01 13:21:40 2019 -0400" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Sun Sep 01 13:21:40 2019 -0400" }, "message": "Fixed render mode (#1377)\n\nThis change (https://github.com/airbnb/lottie-android/pull/1190) was supposed to revert to software rendering when the device can\u0027t allocate a hardware buffer large enough for the animation. However, this would also trigger before a composition loads and the view was set to wrap_content. The width and heigh would be 0 which would cause Android to noop the drawing cache. However, the previous logic here would think that the drawing cache failed to allocate because it was too large.\r\n\r\nI also added some systrace markers and added a default animation view to the issue repro module.\r\n\r\nFixes #1374", "tree_diff": [ { "type": "modify", "old_id": "71b960d84cb0289d2356c0bb0e1a82c704348b9d", "old_mode": 33261, "old_path": "issue-repro/src/main/res/layout/activity_main.xml", "new_id": "90771ced263ae21d07ff2fa747b19346402d41bd", "new_mode": 33261, "new_path": "issue-repro/src/main/res/layout/activity_main.xml" }, { "type": "modify", "old_id": "0c11bac52f2d780f01f5b79b895bc67b40f3f9c2", "old_mode": 33188, "old_path": "lottie/src/main/java/com/airbnb/lottie/LottieAnimationView.java", "new_id": "6890136de4e41369367faebaef85020ca1fd4dd1", "new_mode": 33188, "new_path": "lottie/src/main/java/com/airbnb/lottie/LottieAnimationView.java" }, { "type": "modify", "old_id": "ff9b73d0ffdbd68075fb34065dae2666d87166c7", "old_mode": 33188, "old_path": "lottie/src/main/java/com/airbnb/lottie/LottieDrawable.java", "new_id": "db5381f5f99109e6b769f3bc3b9a4d481f72a8c9", "new_mode": 33188, "new_path": "lottie/src/main/java/com/airbnb/lottie/LottieDrawable.java" }, { "type": "modify", "old_id": "83813d4ab95ab0088dd642a22c6259bd0dd4198a", "old_mode": 33188, "old_path": "lottie/src/main/java/com/airbnb/lottie/animation/keyframe/BaseKeyframeAnimation.java", "new_id": "8439f6436e72a6f08eea75c89ba2b16615203b2d", "new_mode": 33188, "new_path": "lottie/src/main/java/com/airbnb/lottie/animation/keyframe/BaseKeyframeAnimation.java" }, { "type": "modify", "old_id": "65432952aec74a73a9cdbfd3e942b25766b1bf72", "old_mode": 33188, "old_path": "lottie/src/main/java/com/airbnb/lottie/model/layer/BaseLayer.java", "new_id": "970f106ecb77597e92469eea1354af886b19f945", "new_mode": 33188, "new_path": "lottie/src/main/java/com/airbnb/lottie/model/layer/BaseLayer.java" }, { "type": "modify", "old_id": "18638995d0474630b1eb8cc602757b2398d3a283", "old_mode": 33188, "old_path": "lottie/src/main/java/com/airbnb/lottie/utils/LottieValueAnimator.java", "new_id": "4aa70005c9a6025943ba6e74d234b6f1486adec0", "new_mode": 33188, "new_path": "lottie/src/main/java/com/airbnb/lottie/utils/LottieValueAnimator.java" } ] }