tree 1379c4bb11096e4d8996a8b0f2db8f7586dab3cd
parent 13eb1a1662db41fa37a6e7f703b62f225727686e
author Derek Mauro <dmauro@google.com> 1783629351 -0700
committer Copybara-Service <copybara-worker@google.com> 1783629417 -0700

Fix double-free in absl::StatusOr<T>::emplace when value constructor throws

When `emplace()` is called on an `ok()` `StatusOr<T>`, it calls
`Clear()` to destroy the existing object. If the new value's
constructor throws an exception, `status_` was previously left as
`OkStatus`. This caused `~StatusOrData()` to erroneously destroy the
uninitialized memory again during stack unwinding.

This CL fixes the issue by temporarily setting `status_` to an
internal non-ok state (using the zero-allocation inline
representation) before calling `MakeValue()`, restoring it to
`OkStatus` only if construction succeeds.

PiperOrigin-RevId: 945290296
Change-Id: I17111c161f9d3d9f44ae014c49ab76960c7efc7b