PR #2175: Fix use-after-free in linked_hash_set and linked_hash_map move assignment Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/2175 ## Issue Fixes #2174. `linked_hash_set` and `linked_hash_map` move assignment with an unequal, non-propagating allocator leaves the internal `flat_hash_set` of `std::list` iterators pointing at the source's nodes, which the source then frees (`heap-use-after-free`; SIGSEGV without a sanitizer). For `linked_hash_map` the same configuration does not compile at all. ## Root cause `operator=(linked_hash_set&&)` (and the map equivalent) unconditionally did ```cpp set_ = std::move(other.set_); list_ = std::move(other.list_); other.set_.clear(); other.list_.clear(); ``` When `propagate_on_container_move_assignment` is false and the allocators compare unequal, `std::list` cannot take over the source's nodes and re-creates them with the destination's allocator, so the iterators taken over with `set_` dangle as soon as `other.list_.clear()` runs. `std::list`'s move assignment additionally element-assigns in that case, which does not compile for the map's `std::pair<const K, V>` value type. ## Fix Dispatch on `propagate_on_container_move_assignment`: * **true**: propagate the allocator and use the component moves as before; * **false, equal allocators**: take over the nodes with `clear()` + `splice()` (splice relinks the nodes instead of element-assigning, which is also what makes this compile for the map); * **false, unequal allocators**: move each element into a new node allocated with the destination's allocator and rebuild the index over those nodes with the source's hash and equality state, mirroring `raw_hash_set::move_assign`. The operator is no longer unconditionally `noexcept`; it now uses the same specification as `raw_hash_set::operator=(raw_hash_set&&)`: `is_always_equal && is_nothrow_move_assignable<hasher> && is_nothrow_move_assignable<key_equal>`. This is an API change for callers whose allocator is not always equal: the operator can now allocate and throw. It can be split out of this change if preferred. ## Tests Three tests in `linked_hash_set_test.cc` and three in `linked_hash_map_test.cc`, in the style of `ExtractAndEmplaceUseSameStatefulAllocator`. Unequal allocators come from `CountingAllocator` instances with different state pointers, and `MoveAssignPropagatingCountingAlloc` provides a propagating allocator: * `MoveAssignWithUnequalNonPropagatingAllocator`: empty and non-empty destinations; checks `contains`, `find`, `erase`, iteration order, that the destination's old elements are gone, and that the source is empty; * `MoveAssignWithEqualAllocatorTakesOverNodes`: the nodes and the index are taken over without allocating; * `MoveAssignWithPropagatingAllocatorPropagates`: the allocator is propagated even when the allocators are unequal. ## Verification * New tests, unpatched: the set test aborts under ASan with `heap-use-after-free` (`Wrapped::operator()` at `linked_hash_set.h:98`, reached from the test at `linked_hash_set_test.cc:878`) and SIGSEGVs without a sanitizer; the map test does not compile (`std::list` element assignment of `std::pair<const int, int>`). * New tests, patched: pass, plain and ASan. * Full suites, patched: `linked_hash_set_test` 219/219 (plain) and 218 passed + 1 skipped (ASan); `linked_hash_map_test` 341/341 (plain) and 340 passed + 1 skipped (ASan); `raw_hash_set_test` and `raw_hash_set_allocator_test` pass under ASan (no fallout). * The control/trigger PoCs from the issue pass with the patch under both libstdc++ (clang 14) and libc++ (clang 22). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Merge e0a08bbe766042f88cebc12d4b0f6491699c73c3 into e7d5000d632dc1c3f32477b027bf0384b1747325 Merging this change closes #2175 PiperOrigin-RevId: 991220704 Change-Id: I501a52d9ae51da76934e8c9f38176d5b227f015c
The repository contains the Abseil C++ library code. Abseil is an open-source collection of C++ code (compliant to C++17) designed to augment the C++ standard library.
Abseil is an open-source collection of C++ library code designed to augment the C++ standard library. The Abseil library code is collected from Google's own C++ code base, has been extensively tested and used in production, and is the same code we depend on in our daily coding lives.
In some cases, Abseil provides pieces missing from the C++ standard; in others, Abseil provides alternatives to the standard for special needs we've found through usage in the Google code base. We denote those cases clearly within the library code we provide you.
Abseil is not meant to be a competitor to the standard library; we've just found that many of these utilities serve a purpose within our code base, and we now want to provide those resources to the C++ community as a whole.
If you want to just get started, make sure you at least run through the Abseil Quickstart. The Quickstart contains information about setting up your development environment, downloading the Abseil code, running tests, and getting a simple binary working.
Bazel and CMake are the official build systems for Abseil. See the quickstart for more information on building Abseil using the Bazel build system. If you require CMake support, please check the CMake build instructions and CMake Quickstart.
Abseil follows Google's Foundational C++ Support Policy. See this table for a list of currently supported versions compilers, platforms, and build tools.
Abseil contains the following C++ library components:
base base library contains initialization code and other code which all other Abseil code depends on. Code within base may not depend on any other code (other than the C++ standard library).algorithm algorithm library contains additions to the C++ <algorithm> library and container-based versions of such algorithms.cleanup cleanup library contains the control-flow-construct-like type absl::Cleanup which is used for executing a callback on scope exit.container container library contains additional STL-style containers, including Abseil's unordered “Swiss table” containers.crc The crc library contains code for computing error-detecting cyclic redundancy checks on data.debugging debugging library contains code useful for enabling leak checks, and stacktrace and symbolization utilities.flags flags library contains code for handling command line flags for libraries and binaries built with Abseil.hash hash library contains the hashing framework and default hash functor implementations for hashable types in Abseil.log log library contains LOG and CHECK macros and facilities for writing logged messages out to disk, stderr, or user-extensible destinations.memory memory library contains memory management facilities that augment C++'s <memory> library.meta meta library contains type checks similar to those available in the C++ <type_traits> library.numeric numeric library contains 128-bit integer types as well as implementations of C++20's bitwise math functions.profiling profiling library contains utility code for profiling C++ entities. It is currently a private dependency of other Abseil libraries.random random library contains functions for generating pseudorandom values.status status library contains abstractions for error handling, specifically absl::Status and absl::StatusOr<T>.strings strings library contains a variety of strings routines and utilities.synchronization synchronization library contains concurrency primitives (Abseil's absl::Mutex class, an alternative to std::mutex) and a variety of synchronization abstractions.time time library contains abstractions for computing with absolute points in time, durations of time, and formatting and parsing time within time zones.types types library contains non-container utility types.utility utility library contains utility and helper code.Abseil recommends users “live-at-head” (update to the latest commit from the master branch as often as possible). However, we realize this philosophy doesn't work for every project, so we also provide Long Term Support Releases to which we backport fixes for severe bugs. See our release management document for more details.
The Abseil C++ library is licensed under the terms of the Apache license. See LICENSE for more information.
For more information about Abseil: