tree c0e20b3d3de5a562dc2593964be6baec6df96af2
parent 87a28679762f87c43b8bcb64f706f6e1237c68ec
author Jaebaek Seo <jaebaek@google.com> 1623159327 -0400
committer GitHub <noreply@github.com> 1623159327 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgv3IfCRBK7hj4Ov3rIwAAnHwIAAqJ0PFgeeW8iEOlzy7hbojX
 sM61qUc0aQ1BwmdZnNJRaQ6U74mJuTDmQD1WcJlqG6Ysih25fFTOkrc8DacZLPQw
 R8lK0spBPbcaild19zGC1/0OnKp4JypmegeTzuA+ylAWmHk1Euatt/nSIOFsfhFx
 Z2AsSaOoG94jk/Jc1Qnz64M8VlWUGMF1Y/0XunvQ3RO5i01ndRq+dFhSxnULxDYe
 8KEJ8YlM55axYnX7AsKu7JJAP+K3lvAdllORgrClZwmf7hHxJAoMoknlfxkVsR26
 kzt2fLmo0x+tidT/hGH9bGTnOjHDdPP+tmgsgNRrfXlaR4Za/9CzFyMYL2oZzM8=
 =ANY/
 -----END PGP SIGNATURE-----
 

No error report for variable image offset when before-legal-hlsl is on (#4316)

PR #4118 (d71ac38b8e) let spirv-val report a validation error when we
use offset for an OpImage* instruction instead of ConstantOffset. Since
some compilers like DXC rely on spirv-opt for function inlining or loop
unrolling, the spirv-val change broke some working shaders when the
shader developers disable the optimization (spirv-opt).

For example, DXC recently got this issue from a few users e.g.,
https://github.com/microsoft/DirectXShaderCompiler/issues/3807

Since this error is reported only when the spirv-opt is disabled, it
looks like the exact case that we have to skip spirv-val when
`--before-legalize-hlsl` is given. Moreover, avoiding the error using
`--before-legalize-hlsl` on DXC is exactly what FXC and DXC's DXIL
do (they do not report the error if the offset becomes a constant after
function inlining or loop unrolling).