tree 13094ca0826161c6de4dfdb6deb5ca4f525d3083
parent c5d1dab99efcbbdc46364b86bf82fdd82322fc65
author Steven Perron <stevenperron@google.com> 1566407562 -0400
committer GitHub <noreply@github.com> 1566407562 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJdXXuKCRBK7hj4Ov3rIwAAdHIIAFOH92qCT2bjUV7j82al0vSP
 fE5eoLZnFwXis0QXPmwGWYvhBkuYp1fFZhVB1k1ApHsvty1yfvXXrWCfI1RvpChI
 h1CowKccwKj7fwOijtcXzZpbp/N87hmWGWh+YHeXg+qmjNXsWudwObooBYOGmMzO
 RTVBN/pW3rMW0hp9nke2RpNO7+1YSK7z006hN6yJSw8LLfCb7Fj22NEUE4SPdfIf
 PsHS63yjHZmCJpJQxpnvksn3hoe3+HCUCj/pQCmlwAspZyyNsFD9TJFWGIarAtRu
 kMlJQUozBiIldgWdec6lXt4gMe/JqpsUClAUnApWqBQp7nh06Z+72NwKx4CA/NU=
 =Trp6
 -----END PGP SIGNATURE-----
 

Even more id overflow in sroa (#2806)

Now we need to handle id overflow when we overflow while replacing uses of the variable.  While looking at this code, I noticed an error in the way we handle access chains that cannot be replaced because of overflow.  Name it will make some change, and then give up by returning SuccessWithoutChange.  But it was changed.

This is fixed up by returning Failure if we notice the error at the time of rewriting the users.  This is for both id overflow or out-of-bounds accesses.

Code is added to "CheckUses" to remove variables that have out-of-bounds accesses from the candidate list, so we don't even try to rewrite its uses.

Fixes https://crbug.com/995032