tree 9e6f321dc6e9f435e6d2903f33026647fa02fab7
parent e82a428605f6ce0a07337b36f8ba3935c9f165ac
author Alastair Donaldson <afdx@google.com> 1575650297 +0000
committer GitHub <noreply@github.com> 1575650297 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJd6oP5CRBK7hj4Ov3rIwAAdHIIAIBV7XMIlyHkDJ+R2QjfKDCC
 b5JJrKKiTVI00JlcFcC0uArT+6N75V+oz0Au24CA4TZpZm3tIT0p3wi1xOCnlJGR
 jzIFFJp5prANukN9kwSqkaRjjOBIhGw73ng2NnQMiQaarMV1vF0yo4uuNVivklDV
 smNhDPZK2LeFdmG1pnFRm4KRKDkp7y9EgtqRnV1wrvMvlJhz0bJKSIRTvo6++YRm
 XFVCqN+mA3fKnMJf2ZlT09G8+ToEQ4cFcNjp4sbzG2mNM1T3KThk9/ggUO97CTzJ
 Q+45/CYydczaUq174wS3fccHP4pY518xscAAL/xobYNqzhvPys10YwYSBA56ZuI=
 =us/K
 -----END PGP SIGNATURE-----
 

spirv-fuzz: Use validator to check break/continue dominance conditions (#3089)

The passes that add dead breaks and continues suffer from the
challenge that a new control flow graph edge can change dominance
information, leading to the potenital for definitions to no longer
dominate their uses.  The attempt at guarding against this was known
to be incomplete.  This change calls on the SPIR-V validator to do the
necessary checking: in deciding whether adding such an edge would be
legitimate, we clone the module, add the edge, and use the validator
to check whether the transformed clone is valid.

This strategy is heavy-weight, and should be used sparingly, but seems
like a good option when the validity of transformations is intricate,
to avoid reimplementing swathes of validation logic in the fuzzer.

Fixes #2919.