tree 67ee2c5d4a58ba10cde6f5718a5d80010eda9ff4
parent f54b8653dd9d4fb2068c7203b148b4276405bea5
author Diego Novillo <dnovillo@google.com> 1564158820 -0400
committer GitHub <noreply@github.com> 1564158820 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJdOytkCRBK7hj4Ov3rIwAAdHIIAJGwEZDHz2ieQwLzGKXW4gZj
 gZMQMo4v1iUmoZzx7JBbPj46Hsb0tVuMtgqHGf6MPxErN4EL/FiGkjyEIlTMQCYA
 pYSzyf8utTD9q/NmL7zqSZA4NZfJ1U3ldSYxAOfoZIygZ7Sv2avfuELyuckVl4kP
 rHjW0HHofpcSZiC6tPCXh4qFV+E2VxhSVMlJ68MM4RBnkBNuUS9FhZCX9ELOVXqd
 E/7nz7XAUhbVDeYadGmhCp5O7uywGolPTsXk8PScE/wkQV/CgUbZb4gMP0Ix4vLs
 nArtHpF6wSWll40BfJg4qi1CbrjR5XfEiVPItEg6WbUf0XqurjsxyIPaGM3mVRc=
 =112a
 -----END PGP SIGNATURE-----
 

Fix #2609 - Handle out-of-bounds scalar replacements. (#2767)

* Fix #2609 - Handle out-of-bounds scalar replacements.

When SROA tries to do a replacement for an OpAccessChain that is exactly
one element out of bounds, the code was trying to access its internal
array of replacements and segfaulting.

This protects the code from doing this, and it additionally fixes the
way SROA works by not returning failure when it refuses to do a
replacement.  Instead of failing the optimization pass, SROA will now
simply refuse to do the replacement and keep going.

Additionally, this patch fixes the SROA logic to now return a proper status so we can
correctly state that the pass made no changes to the IR if it only found
invalid references.