tree ecba00fe95aeff61ce2829b04cc82dfdaac73d66
parent f0aa6f4e3a57d428725ef91b7005bb4371d78155
author Steven Perron <stevenperron@google.com> 1538158564 -0400
committer GitHub <noreply@github.com> 1538158564 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJbrm/kCRBK7hj4Ov3rIwAAdHIIACxFIHg/BqkEAdRuVdBWK7hG
 +dvATMWzTuZmrvssE+0tlJ7nFEfnHAbj+hfb+H13YI7jdzm9dKbDOpWEohI0JW4f
 xrMvTIzpE1Djtw1Vn6SIrVdXj+3dvNT1k7U3102OLEGmScs5u0Wqd52d6LS7RyUa
 +YeEqX/pdZIrFcbHofRDNjbkmFc1IC60qylN1+/V+zccMfoADOgbzW3wrJUvLpIa
 EOQ1eXtmQ1RvPdU1/h2cSo3Si+O3ZMoZW0e8/8Xzc7xdAk4pMV2o4qNIyBJ2fp8P
 JGMSLDwsptTrw8jxhPjKCqXo4t9ZDavwQ8xRRT7Hq0PifphriyaxGjEv0QQp588=
 =GSAx
 -----END PGP SIGNATURE-----
 

Handle decoration groups with no decorations. (#1921)

In DecorationManager::RemoveDecorationsFrom, we do not remove the id
from a decoration group if the group has no decorations.  This causes
problems because KillNamesAndDecorates is suppose to remove all
references to the id, but in this case, there is still a reference.

This is fixed by adding a special case.

Also, there is the possibility of a double free because
RemoveDecorationsFrom will delete the instructions defining |id| when
|id| is a decoration group.  Later, KillInst would later write to memory
that has been deleted when trying to turn it into a Nop.  To fix this,
we will only remove the decorations that use |id| and not its definition
in RemoveDecorationsFrom.