tree 985381e75b4020d326a94d4723eaf5296dc97b94
parent 9f035269d6849380489044b017676b66699764ad
author Steven Perron <stevenperron@google.com> 1558457100 -0400
committer GitHub <noreply@github.com> 1558457100 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJc5CsMCRBK7hj4Ov3rIwAAdHIIADd/ql74bxzeuJyVV25IiH0i
 Vks3oVlhfB2dLs++dc5Evap4efHjlhk9WRNvchjLQoBpASlHsB+i7KxYWzMZMiKy
 9TJ5++3TPRemYlfTH5uXPsjpLBjLSQvyyfYDQf2DFXJ6bCiTlm2qeAp/GMkPztYZ
 479OlayngOPQJgjAbnZsar7RPITOB038yW5b7QmSilb3uiRqRaIwZESmCPV69ZDf
 GizFIFm1SCyabaDzgw1j/DaVNRdaVqZYGpm6zFp6thCLjiWXIBf6P+GNAsMGtSWV
 M3pCGmTKs8bGFGnpP4R0cd/rd8M45je5l0RboA3PzOQhDubzRT0AD/3Jrb0Qz10=
 =2fx9
 -----END PGP SIGNATURE-----
 

Using the instruction folder to fold OpSpecConstantOp (#2598)

In order to try to reduce code duplication and to be able
to fold more cases, we want to use the instruction folder
when folding an OpSpecConstantOp with constant operands.

A couple other changes are need to make this work.  First
GetDefiningInstruction| in the constant manager is able
to handle |type_id| being logically equivalent to another
type, so we updated the interface, and removed the assert.

Some tests were also updated because we not generate
better code because constants are not duplicated as much
as before.

No need for new tests.  The functionality of the instruction folder is
already tested.  There are tests check that the instruction folder is
being used correctly for OpCompositeExtract and OpVectorShuffle in the
existing test cases.

Fixes #2585.