tree 235669dfab083bb5ae1845bc6ebe572796d2b242
parent d1353632775b86abd4a527c9f6114dda2d4405fa
author Chip Davis <cdavis@codeweavers.com> 1599796278 -0500
committer Chip Davis <cdavis@codeweavers.com> 1600100898 -0500

MVKCmdResolveImage: Fix resolving sub-regions.

When doing multisample resolution in Metal, the dimensions of the MSAA
RT and the resolve destination must be the same. Therefore, if the
resolve region does not cover the entire destination, we must use a
temporary transfer image. This fixes a validation error in the differing
image size tests from the CTS
(`dEQP-VK.api.copy_and_blit.*.resolve_image.diff_image_size.*`).

Because the temporary transfer image has the same dimensions as the
destination and is intended to be resolved to it, copies from the source
should use the destination's parameters for the temp image. That way,
the regions show up in the correct place in the destination. This fixes
the remaining resolve tests.

Don't do expansion blits if the resolve region covers the entire
destination. This should reduce the amount of needless work we do in
that case.