commit a1e33384c19f61c900dd63d986e87d4de298d917
author Bill Hollings <bill.hollings@brenwill.com> Wed Feb 17 13:56:37 2021 -0500
committer Bill Hollings <bill.hollings@brenwill.com> Wed Feb 17 13:56:37 2021 -0500
tree a3b600015db9e9ffdb1acd1fa47905f98203d9c2
parent 0b90a53d76ccccab64fea71ecdb9554f941ecb4b

Remove @synchronized from MTLFunction specialization to avoid reentrant hang.

MoltenVK/MoltenVK/GPUObjects/MVKShaderModule.mm

diff --git a/MoltenVK/MoltenVK/GPUObjects/MVKShaderModule.mm b/MoltenVK/MoltenVK/GPUObjects/MVKShaderModule.mm
index 0c0b3ed..55da1dc 100644
--- a/MoltenVK/MoltenVK/GPUObjects/MVKShaderModule.mm
+++ b/MoltenVK/MoltenVK/GPUObjects/MVKShaderModule.mm
@@ -470,14 +470,12 @@
 	unique_lock<mutex> lock(_completionLock);
 
 	compile(lock, ^{
-		@synchronized (_owner->getMTLDevice()) {
-			[mtlLibrary newFunctionWithName: funcName
-							 constantValues: constantValues
-						  completionHandler: ^(id<MTLFunction> mtlFunc, NSError* error) {
-				bool isLate = compileComplete(mtlFunc, error);
-				if (isLate) { destroy(); }
-			}];
-		}
+		[mtlLibrary newFunctionWithName: funcName
+						 constantValues: constantValues
+					  completionHandler: ^(id<MTLFunction> mtlFunc, NSError* error) {
+			bool isLate = compileComplete(mtlFunc, error);
+			if (isLate) { destroy(); }
+		}];
 	});
 
 	return [_mtlFunction retain];