Fix UI bugs

- Fixes bug where commits are rendered wrong when clicking on a trace. 
  This was caused by a race condition between rendering a dialog and 
  fetching the data over the network. Added commits-loaded event to 
- A related bug cause the commits window to disappear if a user 
  click on a commit in the open event. This was caused by two 
  logically different events having the same name. 
  renamed: "commit-selected" -> "show-commits" 


Change-Id: I1706dd9ffd0567f015f2ce481eea85422b2c54f1
Reviewed-by: Kevin Lubick <>
Commit-Queue: Stephan Altmueller <>
7 files changed
tree: 9f68ac3c3e4f4b26a241be578e61d10d13889599
  1. .gitattributes
  2. .gitignore
  3. DEPS
  5. Makefile
  9. android_ingest/
  10. android_stats/
  11. appengine_scripts/
  12. autoroll/
  13. bash/
  14. blamer/
  15. chromeextensions/
  16. codereview.settings
  18. compute_engine_scripts/
  19. cq_watcher/
  20. ct/
  21. datahopper/
  22. datahopper_internal/
  23. debugger/
  24. doc/
  25. fiddle/
  26. flakiness/
  27. fuzzer/
  28. get_service_account/
  29. go/
  30. golden/
  31. grafana/
  32. grandcentral/
  33. imageinfo/
  34. infra/
  36. logmetrics/
  37. misc/
  38. nsqd/
  39. pdfium/
  40. perdiff/
  41. perf/
  42. prober/
  43. prometheus/
  44. proxy/
  45. pulld/
  46. push/
  47. ragemon/
  48. res/
  49. run_unittests
  50. run_unittests.go
  51. scripts/
  52. site_config/
  53. skfe/
  54. skolo/
  55. status/
  56. task_scheduler/
  57. tools/
  58. tracedb/
  59. webtools/
  60. whitespace.txt
  61. whitespace2.txt

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at Although it is possible to check out this repository directly with git clone or using gclient fetch, it is preferred to use go get so that the code is arranged correctly for Go. If this is your first time working on Go code, read about the GOPATH environment variable. Make sure that $GOPATH/bin comes before /usr/bin in your PATH. If you have GOPATH set, run:

$ go get -u -t

This fetches the repository into your $GOPATH directory along with all the Go dependencies. Note: is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get \ \
$ npm install -g polylint bower

Build from GOPATH:

$ cd $GOPATH/src/
$ make all

Database Setup for Testing

Tests which use the database package's testutils require you to have a MySQL instance running with a database named “sk_testing” and users called “readwrite” and “test_root” with appropriate permissions for sk_testing. The ‘setup_test_db’ script in ‘go/database’ is included for convenience in setting up this test database and user.

Go tests require a local installation of MySQL. For a Debian based distro:

$ sudo apt-get install mysql-client mysql-server

Leave the root password blank.

Then, to set up local versions of the production databases:

$ cd $GOPATH/src/
$ ./setup_test_db

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small