commit | d1ada988ab2103819408432334a6e44520b0ec50 | [log] [tgz] |
---|---|---|
author | Jeff Yoon <jeffyoon@google.com> | Wed May 01 18:21:37 2024 +0000 |
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Wed May 01 19:51:52 2024 +0000 |
tree | 01803945866ac417be86c7728388f95e6b8f8e04 | |
parent | 1a9f8691ccb453dcce64960bf87097b2d8d10d41 [diff] |
[pinpoint] retain swappability of catapult bisect workflow The response object was updated to a new struct object that contains the datastore response, but this makes the response type different from internal.Bisect and makes this workflow less interchangeable with it. The internal.BisectExecution object currently returns a good amount of additional data to generate the information for Catapult. However, it being under the internal package doesn't allow it to be exposed. Anomaly workflows need access to Culprits. To address both, response type is updated to pinpoint_proto, which contains just the information about culprit while being accessible outside of internal. Once the backwards compatibility is no longer needed, the response object of internal.BisectWorkflow can be reverted to the pinpoint_proto and the catapult package can be deleted. Bug: b/327032048 Change-Id: I2b88c9658a3db285dfb44a19f53afcd779d05f2c Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/848487 Commit-Queue: Jeff Yoon <jeffyoon@google.com> Reviewed-by: Prakhar Asthana <pasthana@google.com> Reviewed-by: Leina Sun <sunxiaodi@google.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small