commit | fd048678a3bd90d5bbf2ebd2780fc261a55effec | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Wed Jan 22 15:22:41 2020 -0500 |
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Wed Jan 22 20:23:23 2020 +0000 |
tree | 934e6204db4d784b63a6bdef28bf731d175ac160 | |
parent | 6b3cd24e463fabc232737e27c900a65b38f9d2c2 [diff] |
[gold] test_util.js: Add function setUpElementUnderTest. This function returns a factory function that can be used to instantiate the element under test, and sets up an afterEach() hook to automatically remove it from the DOM after each test. Notes: - It captures the component instantiation pattern currently in place on all our custom element tests. - I'll follow up with a refactor in which tests will rely on this function instead. - This should reduce boilerplate and hopefully make our tests easier to read. - Moving forward, this will reduce the chances of writing buggy tests by e.g. forgetting to clean up the element under test after each test case. Bug: skia:9525 Change-Id: Ic061178c7ca6cd8aa0f75825339dc6fb17605c15 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/265221 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small