| commit | f9ad0db84cbcdd4120dc1e49f1d489f2696a7f62 | [log] [tgz] |
|---|---|---|
| author | seanmccullough <seanmccullough@google.com> | Wed Nov 01 18:27:05 2023 -0700 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Thu Nov 02 16:39:21 2023 +0000 |
| tree | db7ff2223a2cbd2a19e432791a4ed79a04625d59 | |
| parent | ff6ad0da154a83d48ad65fe14f780db219cd0609 [diff] |
[perf UI] support incremental dataframe fetching Adds enableIncrementalDataFrameFetch to State this boolean (default is false) is controlled by a checkbox in the top row of the explore-simple-sk control itself: https://screenshot.googleplex.com/3qBFLxfFpd7zaLV When this value is false, explore-simple-sk should behave exactly as it currently does without this CL. Adds requestFrameBodyDeltaFromState(): FrameRequest this method will attempt to build a FrameRequest for the just the difference between what is currently in this._dataframe, and what is being requested according to this._state.{begin|end}. Updates addTraces to handle incremental dataframe responses - attempts to preserve the existing zoom window bounds, with adjustments for the case of panning to the right - attempts to merge incoming dataframe with the existing dataframe if possible. Changes how the spinner-sk element is positioned and displayed The spinner is now shown *over* the plot-sk element, with opactity: 0.5. Note: This change applies for all spinner activity, not just for cases when enableIncrementalDataFrameFetch is true. Adds timestampBounds() to modules/dataframe this is a helper function to get the earliest and latest timestamps from the dataframe's header values. Bug: b:296467659 Change-Id: I4439971d7277547f447f901eb9f401775b2d85c3 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/768322 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Sean McCullough <seanmccullough@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small