| commit | e9cc1d1c587cfb14c2b3315d66701b114ec03099 | [log] [tgz] |
|---|---|---|
| author | Leandro Lovisolo <lovisolo@google.com> | Tue Aug 09 20:08:23 2022 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Tue Aug 09 23:58:52 2022 +0000 |
| tree | 1d45c1fcc9b108dc48928d81a71cf9a2a62932bc | |
| parent | 1296296b44527eb00fc518b97105d3d2f91afd4b [diff] |
[gold] Add support for multiple datapoints for the same CL/PS/trace. The central change in this CL is adding source_file_id as a primary key for table SecondaryBranchValues. Without this, inserting multiple datapoints for the same CL/PS/trace produces a "duplicate key value violates unique constraint "primary"" CockroachDB error. Testing approach: I searched for any code that queried the SecondaryBranchValues table and added unit tests that cover the case where there are multiple datapoints for the same CL/PS/trace. Deployment steps: Essentially we need to "ALTER TABLE SecondaryBranchValues" on all Gold databases and then deploy a fresh build of the gold-frontend service to all instances. We'll do this for https://skia-infra-gold.skia.org first and wait a couple of days to check that nothing breaks, then for https://lottie-animation-community-gold.skia.org, then for https://gold.skia.org, then for all other instances. Note to reviewer: I did not find any queries that assume a single SecondaryBranchValues row per CL/PS/trace, but please feel free to double check. Suggested review order: - //golden/go/sql/schema/tables.go - //golden/go/sql/schema/sql.go - //golden/go/sql/datakitchensink/kitchensink.go - //golden/go/sql/datakitchensink/kitchensink_test.go - //golden/go/search/search_test.go - //golden/go/ingestion_processors/testdata/tryjob_rerun.json - //golden/go/ingestion_processors/tryjob_ingestion_test.go - All other changes. Bug: skia:12149 Change-Id: I698e77d67a52d75eb91c3fffe3656c94fd03e7dd Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/565796 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install \
jq \
python-django
$ go get -u \
github.com/kisielk/errcheck \
golang.org/x/tools/cmd/goimports \
go.chromium.org/luci/client/cmd/isolate \
go get github.com/mikefarah/yq/v4
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small