| commit | df410e86df188dbdbc820fc6e67f29d75e98266b | [log] [tgz] |
|---|---|---|
| author | Eric Boren <borenet@google.com> | Fri Jun 21 14:44:51 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Fri Jun 21 14:52:35 2024 +0000 |
| tree | 2c07fa970b10d2eaf12647f0b01f44a753da9ab0 | |
| parent | 43d47421da25de9c978099125acb7e367bafa2c7 [diff] |
[autoroll] Log fewer errors during find-and-replace process We have at least one autoroller with a lot of transitive deps which also uses find-and-replace. In this case, we're find-and-replacing in submodule links, which each contain a single dependency reference. The current code will log an error for each transitive dep which isn't found in every submodule link, which is undesirable. Additionally, we have code in updateSingleDep which automatically detects whether we have a submodule link that needs to be updated. That gets done before the find-and-replace occurs, which means the find-and- replace has no effect in some cases. Only log an error if nothing has produced a change in that file. Finally, fix a potential issue where we fetch the file from Gitiles instead of checking our local changes first during find-and-replace. I have not seen evidence that this has caused a real problem, but it could be relevant if the same file appears multiple times between find-and-replace configs and the primary dependency file. Change-Id: I9a67a5806b37637f9701f930d9b65a1869f4437a Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/868816 Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Eric Boren <borenet@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small