commit | 4794442767ba4b04dd2b3a66674d22c387f9955e | [log] [tgz] |
---|---|---|
author | Kevin Lubick <kjlubick@google.com> | Tue Nov 12 15:14:15 2019 -0500 |
committer | Kevin Lubick <kjlubick@google.com> | Tue Nov 12 21:12:48 2019 +0000 |
tree | cf614dbd72ef534224f12b637ff7387b45f34c21 | |
parent | 01fdb2b69506c3967dff20ed475ec20c698d99ed [diff] |
[gold] Use pre-slicing during normal searches This appears to decrease the latency of /json/search by 2x or more. Timings of /json/search on skia-gold-public instance for the search (average of 3) (~1 million traces): Before: clicking a blame from the front page: 4.8s Untriaged of 3 specific tests: 2.5s All untriaged gms: 4.5s All untriaged image: 5.9s After: Before: clicking a blame from the front page: 2.2s Untriaged of 3 specific tests: 0.2s All untriaged gms: 3.3s All untriaged image: 3.2s Some profiling with this in place reveals: - The polymer v1 page still takes a long time to render (1-3 seconds) - Most of the server time spent searching is in iterTile (util.go), which could easily be run in parallel. - Diffing images is still expensive, but warming the untriaged ones keeps that contribution to the total search time down (usually < 100ms). Diffing image can result in the long tail of wait times (if it takes tens of seconds, for example). - The JSON encoding/gzipping of the results is non-negligible, but small(60-100ms) [for ~200kb of gzipped data] Bug: skia:9080 Change-Id: I731797e212498b37484e4f9e16da228ade69c8e3 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/254178 Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small