commit | d8a188cf6e2fdf3afab3afa520dd3bc122fd758e | [log] [tgz] |
---|---|---|
author | Kevin Lubick <kjlubick@google.com> | Fri Feb 19 08:50:53 2021 -0500 |
committer | Kevin Lubick <kjlubick@google.com> | Mon Feb 22 12:21:14 2021 +0000 |
tree | 61eb81eec7d10083ed5c1d50ec5ddef6a8f7d8f7 | |
parent | 54da6ec3604bde35a9997f50f0f44e14da3c894f [diff] |
[gold] Make diffcalculators fully respect ctx.Done() The big idea here is to replace a for loop over the range of a channel with an infinite for loop that has a select statement at the top to make use of the ctx. Reminder that errgroups do not actually kill all the spawned goroutines for you - they must terminate themselves by listening to the returned errctx. Additionally, we close the channels if we can't calculate the work. This assuredly stops the goroutines we stopped. Bug: skia:10582 Change-Id: I21ebd22116127bce4ff39887c49cfa6d7462ecfc Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/372389 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
Get mockery and add it to your PATH.
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small