commit d5f13e10f8d0ca6f457dbf56aeed70c096f48d25
author Leandro Lovisolo <lovisolo@google.com> Fri Jul 31 19:38:35 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jul 31 23:53:29 2020 +0000
tree d88c6711297ac16b46a2143135ae45ca04581ed1
parent 020cc383246b9e44b5f4e930844f8bbf81226b08

[gold] ignores-page-sk_test.js: Unskip back/forward browser button test.

Change-Id: Ieeae2ab309344e5a406dcf70e732cdf643511abc
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/306317
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

golden/modules/ignores-page-sk/ignores-page-sk_test.js

diff --git a/golden/modules/ignores-page-sk/ignores-page-sk_test.js b/golden/modules/ignores-page-sk/ignores-page-sk_test.js
index cc19f9c..4beedfd 100644
--- a/golden/modules/ignores-page-sk/ignores-page-sk_test.js
+++ b/golden/modules/ignores-page-sk/ignores-page-sk_test.js
@@ -4,6 +4,7 @@
 import { fetchMock } from 'fetch-mock';
 import {
   eventPromise,
+  eventSequencePromise,
   expectQueryStringToEqual,
   setQueryString,
   setUpElementUnderTest,
@@ -99,9 +100,7 @@
       expectQueryStringToEqual('');
     });
 
-    it.skip('responds to back and forward browser buttons', async () => {
-      // TODO(kjlubick,lovisolo) goBack/goForward only waits until one
-      //   fetch returns - maybe eventPromise should be updated for that?
+    it('responds to back and forward browser buttons', async () => {
       // Create some mock history so we can use the back button.
       setQueryString('?count_all=true');
       setQueryString('');
@@ -261,17 +260,15 @@
 }
 
 async function goBack() {
-  const event2 = eventPromise('end-task');
-  const event = eventPromise('end-task');
+  // Wait for /json/ignores and /json/paramset RPCs to complete.
+  const events = eventSequencePromise(['end-task', 'end-task']);
   history.back();
-  await event;
-  return event2;
+  await events;
 }
 
 async function goForward() {
-  const event2 = eventPromise('end-task');
-  const event = eventPromise('end-task');
+  // Wait for /json/ignores and /json/paramset RPCs to complete.
+  const events = eventSequencePromise(['end-task', 'end-task']);
   history.forward();
-  await event;
-  return event2;
+  await events;
 }