| commit | d5d8e26b73db6fbeb1dc7ed9eb661c6a6c228628 | [log] [tgz] |
|---|---|---|
| author | Leina Sun <sunxiaodi@google.com> | Wed Jul 10 21:55:09 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Wed Jul 10 22:07:17 2024 +0000 |
| tree | 938b31383fba375cb054801374a5df7718d1ea7c | |
| parent | 365d4a0b937fa17ac31207fc4c7e68dbb393d435 [diff] |
[pinpoint] verify culprit against previous commit instead of starting commit in culprit finder workflow In the sandwich verification workflow between commits A vs B we run: - regression verification (A vs B) - bisect (A vs B) - culprit verification (C-1 vs C) The culprit verification step ideally compares the culprit against the commit prior to the culprit (C-1 vs C). However, bisection only returns a list of culprits. Since culprit verification does not have access to the commit prior, we do a suboptimal comparison A vs C. This comparison works but it would be better to do C-1 vs C. This CL adds DetailedCulprits to the `BisectionExecution`, which contains the culprit and the commit prior to enable C-1 vs C comparisons. Bug: b/340220164 Change-Id: I30cca9c7cf11b15f228b1cce68a4249d4bc48b49 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/870753 Reviewed-by: Jeff Yoon <jeffyoon@google.com> Commit-Queue: Leina Sun <sunxiaodi@google.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small