| commit | d1864bdf0265107d8280724f8767e6a9960903f5 | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Fri Nov 15 13:32:45 2019 -0500 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri Nov 15 19:26:05 2019 +0000 |
| tree | 09abe0bc6d04fd4539de0c0c3caf987996bb9160 | |
| parent | 0e14ae66aa226821e981bbd4c63dc8d07776997a [diff] |
[gold] Reduce memory by not locking SearchIndex in warmer closure After adding in the pre-slice maps, we were accidentally keeping around all the traces in that map because the search index was locked away in a closure when warming Since warming takes 15 minutes or so and we refreshed a tile after 5 minutes, we were keeping an extra 3-4 traces around. This appears to help calm down the memory usage again. I spent some time looking at bt_tracestore again, because the memory blame blames things in loadEncodedTraces that I would have thought would have been GC'd, but I now believe that go does something clever when copying things around that might make it look like they are still there but are not. Additionally, we were incorrectly keeping the row keys around, which can be prevented with a copy, just like in Perf. Change-Id: I0e913330c10ddccc3cea4d794b2d447a8eb92ea1 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/254800 Reviewed-by: Ben Wagner aka dogben <benjaminwagner@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small