| commit | cfc32e173bb45a0d30c22e2c3e7066073aa40288 | [log] [tgz] |
|---|---|---|
| author | Kevin Lubick <kjlubick@google.com> | Tue Jul 14 14:24:51 2020 -0400 |
| committer | Kevin Lubick <kjlubick@google.com> | Tue Jul 14 18:42:06 2020 +0000 |
| tree | c81effeb7bf6adb447669cbc3d7ef4a6f6d128db | |
| parent | ddec7447f21cafd641614e65ebe3ecb88749ef00 [diff] |
[gold] Initial cluster-page-sk Explicit changes from old version: - The cluster selection is limited to the query and the toggles. In the old version the right-hand side query (and all the other filters) could be applied, but I don't think that really makes sense for clustering. Those filters are fine when you are thinking about two digests, but don't apply in an obvious way for N digests. So, I've removed them. - Dragging nodes around is not supported. It makes things simpler, and we probably don't need it. - The query params to the cluster page are different and no longer coupled to the query params passed to the backend RPC call. This will require changes to places that link in. Idea: have a given page export helpers for how to make a link to that appropriate page. - There's no tabbing for showing a details and a params. It's one or the other depending on what is selected. Also, the layout is a little different to hopefully be more gentle on narrower screens. Changes that could/should/will still be implemented: - bulk triage selected digests - clicking on summarizing paramset should do something to cluster. - Have the cluster-digests-sk take up more horizontal space (with some forces to keep it more in view). - Hide filter button on search-controls-sk via a property. Note: Current PageObject(Element) did not seem sufficient for dealing with clicking the svg stuff. Instead, I shared the click and shiftClick methods, which seems to work ok despite this. Bug: skia:9525 Change-Id: Ic1d18b50f6ee547b54e2524ee96ec79fd8188acf Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/301005 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small