commit | cf2d06128d2f83008510df5a54417cefce80572a | [log] [tgz] |
---|---|---|
author | Kevin Lubick <kjlubick@google.com> | Wed May 06 07:39:14 2020 -0400 |
committer | Kevin Lubick <kjlubick@google.com> | Wed May 06 13:35:58 2020 +0000 |
tree | 28101e17fc8135ea16ebfb48cf5c9df076062006 | |
parent | 988474ac727f1bd5cb6fba34f44fc3068428b904 [diff] |
[gold] Remove commenting logic from ingestion Comments are noisy and having the logic to decide to comment be (essentially) at the point of ingestion makes it hard to play around with that data. This logic will be deduplicated with the logic in the search API, i.e. UntriagedUnignoredTryJobExclusiveDigests. This is now possible because of the CL indices that make the search API fast and not overload the Firestore backend. Bug: skia:10218 Change-Id: Ia21f68e35e43a9b279e626f47401b3ac3783d570 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/287880 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small