Google Git
Sign in
skia / buildbot / 77ae6a2042d8e380f52e4dd195bbd4ac6666767a
commit77ae6a2042d8e380f52e4dd195bbd4ac6666767a[log] [tgz]
authorAshwin Verleker <ashwinpv@google.com>Thu Oct 12 18:57:46 2023 +0000
committerSkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com>Thu Oct 12 19:11:42 2023 +0000
treeec19f357dcc0eb4b73ed29a2aeb32f665ec2c5c6
parenta1666bf633a86117f0e9e6a8e73399309879e812 [diff]
Fix query selection when loading page with url

- Currently if you open the explore page with a pre-crafted url, open the query dialog and make a change to the query params, only the newly selected params are reflected.
- The current query param selection in the query-sk is done via the current_query attribute.
- However when loading the page like this, we weren't setting the paramset for the query-sk before setting the current_query attr. This caused the setting of selected params to reset since the paramset did not have the required keys at that stage (see the rationalizeQuery function in query-sk.ts).
- In this change we just set the paramset first and then set the current_query attribute.

Bug: b/301786467
Change-Id: I84d84e8eadf06e5ae4796437604c619d22dc8625
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/765605
Reviewed-by: Sean McCullough <seanmccullough@google.com>
Commit-Queue: Ashwin Verleker <ashwinpv@google.com>
1 file changed
tree: ec19f357dcc0eb4b73ed29a2aeb32f665ec2c5c6
  1. am/
  2. android_ingest/
  3. android_stats/
  4. api/
  5. autoroll/
  6. bash/
  7. bazel/
  8. bisection/
  9. blamer/
  10. bugs-central/
  11. cabe/
  12. cd/
  13. cherrypick-watcher/
  14. cmd/
  15. codereview-watcher/
  16. codesize/
  17. comments/
  18. comp-ui/
  19. cq_watcher/
  20. ct/
  21. datahopper/
  22. debugger-app/
  23. demos/
  24. docker/
  25. docker_pushes_watcher/
  26. docs/
  27. docsyserver/
  28. ds/
  29. elements-sk/
  30. email/
  31. external/
  32. fiddlek/
  33. firestore/
  34. get_service_account/
  35. gitsync/
  36. go/
  37. gold-client/
  38. golden/
  39. helloworld/
  40. infra/
  41. infra-sk/
  42. jsdoc/
  43. jsfiddle/
  44. k8s-checker/
  45. k8s-deployer/
  46. kube/
  47. leasing/
  48. licenses/
  49. machine/
  50. make/
  51. modules/
  52. named-fiddles/
  53. new_element/
  54. npm-audit-mirror/
  55. perdiff/
  56. perf/
  57. periodic-trigger/
  58. proberk/
  59. promk/
  60. puppeteer-tests/
  61. sa-keys-checker/
  62. scrap/
  63. scripts/
  64. shaders/
  65. sk/
  66. skbug/
  67. skcq/
  68. skfe/
  69. skolo/
  70. skottie/
  71. static_server/
  72. status/
  73. task_driver/
  74. task_scheduler/
  75. test-service/
  76. tools/
  77. tree_status/
  78. trybot_updater/
  79. .bazelignore
  80. .bazelrc
  81. .bazelversion
  82. .eslintrc.js
  83. .gitattributes
  84. .gitignore
  85. .npmrc
  86. .prettierignore
  87. .prettierrc.json
  88. .puppeteerrc.js
  89. .vpython
  90. BAZEL_CHEATSHEET.md
  91. BUILD.bazel
  92. build_infra_prod.sh
  93. CDB.md
  94. cipd.ensure
  95. codereview.settings
  96. DATASTORE.md
  97. demopage.sh
  98. DEPS
  99. go.mod
  100. go.sum
  101. go_repositories.bzl
  102. karmatest.sh
  103. launch.md
  104. LICENSE
  105. Makefile
  106. OWNERS
  107. package-lock.json
  108. package.json
  109. PRESUBMIT.py
  110. PRIVACY_POLICY.md
  111. README.md
  112. STYLEGUIDE.md
  113. tools.go
  114. tsconfig.json
  115. whitespace.txt
  116. WORKSPACE
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Install dependencies

Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:

go install github.com/bazelbuild/bazelisk@latest
go install github.com/bazelbuild/buildtools/buildifier@latest
go install github.com/kisielk/errcheck@latest
go install golang.org/x/tools/cmd/goimports@latest
go install github.com/mikefarah/yq/v4@latest
go install go.chromium.org/luci/client/cmd/...@latest

Install other dependencies:

sudo apt-get install jq

Build ~everything

bazelisk build --config=mayberemote //...

Test everything

bazelisk test --config=mayberemote //...

Generated Code

To update generated code run the following in any directory:

go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

./run_unittests --small