Google Git
Sign in
skia / buildbot / c9bd5f30bb415711fbbcd5b9497aff910af76263
commitc9bd5f30bb415711fbbcd5b9497aff910af76263[log] [tgz]
authorKevin Lubick <kjlubick@google.com>Mon Feb 08 10:20:25 2021 -0500
committerKevin Lubick <kjlubick@google.com>Thu Feb 11 16:05:25 2021 +0000
tree2b2306e48612800f921f05e95d20766c61308c02
parent095f1b57fd1471a5ea0f31fd7f8f1ec7e59031a9 [diff]
[gold] Only compute diff metrics against non-ignored images.

In the skia repo, there is a heavy tail of a few tests that
have thousands of unignored images. Computing a full n by n
comparison would take hours and be mostly useless data anyway.

As such, we only compare against non-ignored images, to decrease
computation. Reminder: our goal is to be able to answer the
question "What is the closest positively or negatively triaged
image to any given image" and the answer to that should only come
from not-ignored traces.

Bug: skia:10582
Change-Id: Icab08916b77f2f5c92f71504d2e47cabf5196953
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/366960
Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
9 files changed
tree: 2b2306e48612800f921f05e95d20766c61308c02
  1. am/
  2. android_ingest/
  3. android_stats/
  4. api/
  5. autoroll/
  6. bash/
  7. bazel/
  8. blamer/
  9. bugs-central/
  10. chromeextensions/
  11. codereview-watcher/
  12. comments/
  13. contestk/
  14. cq_watcher/
  15. ct/
  16. datahopper/
  17. debugger-app/
  18. demos/
  19. docker/
  20. docker_pushes_watcher/
  21. docs/
  22. docserverk/
  23. dot/
  24. ds/
  25. external/
  26. fiddlek/
  27. firestore/
  28. get_service_account/
  29. git_cookie_authdaemon/
  30. gitsync/
  31. go/
  32. gold-client/
  33. golden/
  34. hashtag/
  35. html-template-minifier/
  36. infra/
  37. infra-sk/
  38. jsdoc/
  39. jsfiddle/
  40. k8s-checker/
  41. kube/
  42. leasing/
  43. licenses/
  44. machine/
  45. make/
  46. modules/
  47. named-fiddles/
  48. new_element/
  49. particles/
  50. perdiff/
  51. perf/
  52. periodic-trigger/
  53. power/
  54. proberk/
  55. promk/
  56. pulld/
  57. puppeteer-tests/
  58. push/
  59. scrap/
  60. scripts/
  61. shaders/
  62. sk8s/
  63. skbug/
  64. skfe/
  65. skolo/
  66. skottie/
  67. status/
  68. task_driver/
  69. task_scheduler/
  70. tools/
  71. tree_status/
  72. trybot_updater/
  73. velero/
  74. .bazelignore
  75. .bazelrc
  76. .eslintrc.js
  77. .gitattributes
  78. .gitignore
  79. .mocharc.json
  80. BUILD.bazel
  81. build_infra_prod.sh
  82. cipd.ensure
  83. codereview.settings
  84. DATASTORE.md
  85. DEPS
  86. go.mod
  87. go.sum
  88. go_repositories.bzl
  89. launch.md
  90. LICENSE
  91. Makefile
  92. package-lock.json
  93. package.json
  94. PRESUBMIT.py
  95. PRIVACY_POLICY.md
  96. README.md
  97. run_unittests
  98. run_unittests.go
  99. STYLEGUIDE.md
  100. tools.go
  101. tsconfig.json
  102. whitespace.txt
  103. WORKSPACE
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \

Get mockery and add it to your PATH.

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small