tree d238c7a1444cf4eba8debc1463bef61f76eac648
parent cfd3295c3d250e660f2a221df6b43f1cf33b236e
author Leandro Lovisolo <lovisolo@google.com> 1603315585 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1603315634 +0000

[gold] skiacorrectness.go: Extract JSON routes into add*JSONRoutes().

This refactor takes all the code in mustMakeRootRouter() that defines JSON routes, and moves it into new functions addAuthenticatedJSONRoutes() and addUnauthenticatedJSONRoutes(), according to their authentication requirements.

Some benefits of this change:

- Routing code is a bit easier to read and reason about.

- Each function is only passed the router with the necessary authentication middleware, eliminating the opportunity for mistakenly adding a sensitive route to an unauthenticated router.

This is part of a string of CLs aimed at simplifying our routing logic, and eventually consolidating our RPC versioning logic in one single place that can be shared between the skiacorrectness and baseline_server binaries.

Bug: skia:10816
Change-Id: Iffdda49558225f3ec9528356bc1773e789b71258
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/327326
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>