| commit | c78c1676af5a95283f7393cabb4d24a697ae0f7b | [log] [tgz] |
|---|---|---|
| author | Eduardo Yap <eduardoyap@google.com> | Fri Oct 17 09:02:37 2025 -0700 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Fri Oct 17 09:05:36 2025 -0700 |
| tree | a10c47ba5b63347b6b670e2f80e631ffed8058b7 | |
| parent | dbde1b737ecda64d37ea88c068fd64fc8998b617 [diff] |
Revert "Perf: Allow semicolons in param keys/values and improve sanitization logging" This reverts commit 9602f241b417dfd4d46655dffa6ea1c69939bbd6. Reason for revert: Causing ingestion errors due to ";" being an invalid character in query.go Original change's description: > Perf: Allow semicolons in param keys/values and improve sanitization logging > > This commit updates the invalid character regex in various > performance dashboard configurations to permit semicolons. > > It also refactors the sanitization logic in parser.go to > efficiently sanitize and log invalid characters found in keys > and values, and adds tests for this new logic in parser_test.go. > > Bug: b/452106927 > Change-Id: I7787045135782ba50a60c47492759f8d2fcdfa58 > Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1076116 > Commit-Queue: Eduardo Yap <eduardoyap@google.com> > Reviewed-by: Ashwin Verleker <ashwinpv@google.com> Bug: b/452106927 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ie486cff4f6bf7a42deb407012af982aec9f1a7c3 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/1077976 Commit-Queue: Eduardo Yap <eduardoyap@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
This repo contains infrastructure code for Skia.
The infrastructure code is generally built to run on x86 linux. Running on other platforms may be possible but is not officially supported and success will vary depending on the command.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:
go install github.com/bazelbuild/bazelisk@latest go install github.com/bazelbuild/buildtools/buildifier@latest go install github.com/kisielk/errcheck@latest go install golang.org/x/tools/cmd/goimports@latest go install github.com/mikefarah/yq/v4@latest go install go.chromium.org/luci/client/cmd/...@latest
export PATH=$PATH:$(go env GOPATH)/bin
sudo apt-get install jq
bazelisk build --config=mayberemote //...
This step might be an optional step, but some test requires these enviornment variables.
Runs
./scripts/run_emulators/run_emulators start
The following are example of environment variables.
Emulators started. Set environment variables as follows: export DATASTORE_EMULATOR_HOST=localhost:8891 export BIGTABLE_EMULATOR_HOST=localhost:8892 export PUBSUB_EMULATOR_HOST=localhost:8893 export FIRESTORE_EMULATOR_HOST=localhost:8894 export COCKROACHDB_EMULATOR_HOST=localhost:8895
And stores these environment variables to ~/.bashrc file.
bazelisk test --config=mayberemote //...
To update generated code run the following in any directory:
go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
./run_unittests --small