Google Git
Sign in
skia / buildbot / bf43c88d732d8c0bc8b3c276d8974efc299f37fe
commitbf43c88d732d8c0bc8b3c276d8974efc299f37fe[log] [tgz]
authorLeandro Lovisolo <lovisolo@google.com>Thu Oct 08 04:13:06 2020 -0400
committerSkia Commit-Bot <skia-commit-bot@chromium.org>Thu Oct 08 16:39:11 2020 +0000
tree5f54af4010e8e595dd467be97470b4de2294c49c
parent459bf32f76eee13bbb774950b3d2b45cf95f6547 [diff]
[gold] search-page-sk: Fix UI bug which shows stale labels after a triage action.

Steps to reproduce:

  1. Go to the search page. Ensure that the search results contain at least two digests.
  2. Press "J" to focus on the first digest.
  3. Press "A", "S" or "D" to change the first digest's label to positive, negative or untriaged, respectively. The specific label does not matter as long as it's different from the initial one.
  4. Press "J" to advance to the second digest.
  5. Press "K" to go back to the first digest.
  6. The first digest should have reverted to its original label.

For an overview of the bugfix please see the comments in search-page-sk_test.ts and search-page-sk.ts.

Bug: skia:9525
Change-Id: Ia7f6c18cdd3310b4b11d66a467a7d62ed7b29f4e
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/323880
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
4 files changed
tree: 5f54af4010e8e595dd467be97470b4de2294c49c
  1. am/
  2. android_ingest/
  3. android_stats/
  4. api/
  5. autoroll/
  6. bash/
  7. blamer/
  8. chromeextensions/
  9. comments/
  10. contestk/
  11. cq_watcher/
  12. ct/
  13. datahopper/
  14. debugger/
  15. debugger-app/
  16. debugger-assets/
  17. demos/
  18. docker/
  19. docker_pushes_watcher/
  20. docs/
  21. docserverk/
  22. dot/
  23. ds/
  24. fiddlek/
  25. firestore/
  26. get_service_account/
  27. git_cookie_authdaemon/
  28. gitsync/
  29. go/
  30. gold-client/
  31. golden/
  32. hashtag/
  33. html-template-minifier/
  34. infra/
  35. infra-sk/
  36. jsdoc/
  37. jsfiddle/
  38. k8s-checker/
  39. kube/
  40. leasing/
  41. licenses/
  42. machine/
  43. make/
  44. named-fiddles/
  45. new_element/
  46. particles/
  47. perdiff/
  48. perf/
  49. periodic-trigger/
  50. power/
  51. proberk/
  52. promk/
  53. pulld/
  54. puppeteer-tests/
  55. push/
  56. res/
  57. scripts/
  58. sheriff_emails/
  59. sk8s/
  60. skbug/
  61. skfe/
  62. skolo/
  63. skottie/
  64. status/
  65. task_driver/
  66. task_scheduler/
  67. tools/
  68. tree_status/
  69. trybot_updater/
  70. velero/
  71. webtools/
  72. .bazelrc
  73. .eslintrc.js
  74. .gitattributes
  75. .gitignore
  76. .mocharc.json
  77. BUILD.bazel
  78. build_infra_prod.sh
  79. cipd.ensure
  80. codereview.settings
  81. DATASTORE.md
  82. DEPS
  83. go.mod
  84. go.sum
  85. launch.md
  86. LICENSE
  87. Makefile
  88. package-lock.json
  89. package.json
  90. PRESUBMIT.py
  91. PRIVACY_POLICY.md
  92. README.md
  93. run_unittests
  94. run_unittests.go
  95. STYLEGUIDE.md
  96. tools.go
  97. tsconfig.json
  98. whitespace.txt
  99. WORKSPACE
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate
$ npm install -g polylint bower

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \
  github.com/vektra/mockery/...

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small