Fixes for a few UI bugs - Fix b/352285671 by forcing the queryCount to update when query dialog is opened on an existing trace. - Fix b/352287461 and b/352289043 with updating the configs for v8-perf instance. Bug: b/352285671 Change-Id: Iaa9e16f5d248ee4b3ef6d5ac7158d581c1ceb32f Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/875317 Auto-Submit: Ashwin Verleker <ashwinpv@google.com> Commit-Queue: Vidit Chitkara <viditchitkara@google.com> Reviewed-by: Vidit Chitkara <viditchitkara@google.com>
diff --git a/perf/configs/v8-perf.json b/perf/configs/v8-perf.json index 3c7e11a..7c8e5ce 100644 --- a/perf/configs/v8-perf.json +++ b/perf/configs/v8-perf.json
@@ -4,7 +4,6 @@ "trace_sample_proportion": 0.01, "fetch_chrome_perf_anomalies": true, "bug_host_url": "https://bugs.chromium.org", - "filter_parent_traces": true, "feedback_url": "http://go/berf-skia-feedback", "chat_url": "http://go/berf-skia-chat", "notify_config": { @@ -47,7 +46,8 @@ "test", "subtest_1", "subtest_2", - "subtest_3" + "subtest_3", + "subtest_4" ], "default_param_selections": { "stat": ["value"]
diff --git a/perf/modules/explore-simple-sk/explore-simple-sk.ts b/perf/modules/explore-simple-sk/explore-simple-sk.ts index 9a08b3b..aec9127 100644 --- a/perf/modules/explore-simple-sk/explore-simple-sk.ts +++ b/perf/modules/explore-simple-sk/explore-simple-sk.ts
@@ -1293,6 +1293,12 @@ this._render(); this._dialogOn = true; this.queryDialog!.showModal(); + // If there is a query already plotted, update the counts on the query dialog. + if (this._state.queries.length > 0) { + this.queryCount!.current_query = this.applyDefaultsToQuery( + this.query!.current_query + ); + } } /** Open the bisect dialog box. */