| commit | b5d7e166204e515caccf716ee47a4ceffee99f37 | [log] [tgz] |
|---|---|---|
| author | Leandro Lovisolo <lovisolo@google.com> | Thu May 28 19:20:11 2020 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri May 29 18:14:11 2020 +0000 |
| tree | 42027a4d9f50572cfef0fdc8e340fe8312f81d62 | |
| parent | e4e45d0508d8770a24cb9c52cec0118b54553259 [diff] |
[ct] task-queue-sk_test.js: Fix assertion.
This fixes the following error:
Error: Invalid Chai property: class. Did you mean "has"?
Somehow the "expect(...).to.have.class('foo')" syntax stopped working after moving to the TypeScript-enabled Webpack configuration. Probably some kind of issue with the npm dependencies.
Two possible fixes:
1. Rewrite test to make an assertion directly against the element's className property.
2. Explicitly add support for the "to.have.class" syntax via chai-dom[1] and karma-chai-dom[2].
I chose to go with option 1 because it's the simplest and because AFAIK there's no other test in the repo that uses this syntax, but we can always switch to option 2 if anyone is interested.
[1] https://github.com/nathanboktae/chai-dom.
[2] https://github.com/nathanboktae/karma-chai-dom.
Bug: skia:10292
Change-Id: I8fcfaa9c2d3373558b3f97b2848f0950794f17eb
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/292735
Reviewed-by: Weston Tracey <westont@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate $ npm install -g polylint bower
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \ github.com/vektra/mockery/...
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small