| commit | b53ef752541e29a198706d93e859f8c048bf502c | [log] [tgz] |
|---|---|---|
| author | Joe Gregorio <jcgregorio@google.com> | Fri Feb 19 13:42:57 2021 -0500 |
| committer | Joe Gregorio <jcgregorio@google.com> | Fri Feb 19 19:00:51 2021 +0000 |
| tree | ecc3fa1dcc980eaf94f1e17ea755e8f08529153e | |
| parent | 1607e1488356b275a0bb76d3589566bbfea2856f [diff] |
[perf] Fix Android Group By regression detection. This previous change broke regression detection in any instance that uses Group By alerts: https://skia-review.googlesource.com/c/buildbot/+/369845 The root of the problem is that the Alert configs produced by PubSub ingestion driven regression detection were being expanded across all their GroupBy values, which is exactly the thing that ingestion driven regression was built to avoid. So in theory the clusters would have found the regressions eventually, we would just have needed 100x the number of cores. This CL: - Restores the optimized behavior of ingestion driven regression detection. - Adds in more logging. - Sends more info back to the user via Process messages. - Add Prometheus alerts to catch such issues in the future. Change-Id: I8ed956159984ab7a9f15f28f88eb1f89c6c1a5b6 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/372057 Commit-Queue: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
Get mockery and add it to your PATH.
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small