[perf] Fix Android Group By regression detection.

This previous change broke regression detection in any instance
that uses Group By alerts:

  https://skia-review.googlesource.com/c/buildbot/+/369845

The root of the problem is that the Alert configs produced
by PubSub ingestion driven regression detection were being
expanded across all their GroupBy values, which is exactly
the thing that ingestion driven regression was built to avoid.
So in theory the clusters would have found the regressions
eventually, we would just have needed 100x the number of cores.

This CL:

 - Restores the optimized behavior of ingestion driven
regression detection.
 - Adds in more logging.
 - Sends more info back to the user via Process messages.
 - Add Prometheus alerts to catch such issues in the future.

Change-Id: I8ed956159984ab7a9f15f28f88eb1f89c6c1a5b6
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/372057
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
Reviewed-by: Kevin Lubick <kjlubick@google.com>
12 files changed
tree: ecc3fa1dcc980eaf94f1e17ea755e8f08529153e
  1. .bazelignore
  2. .bazelrc
  3. .eslintrc.js
  4. .gitattributes
  5. .gitignore
  6. .mocharc.json
  7. BUILD.bazel
  8. DATASTORE.md
  9. DEPS
  10. LICENSE
  11. Makefile
  12. PRESUBMIT.py
  13. PRIVACY_POLICY.md
  14. README.md
  15. STYLEGUIDE.md
  16. WORKSPACE
  17. am/
  18. android_ingest/
  19. android_stats/
  20. api/
  21. autoroll/
  22. bash/
  23. bazel/
  24. blamer/
  25. bugs-central/
  26. build_infra_prod.sh
  27. chromeextensions/
  28. cipd.ensure
  29. codereview-watcher/
  30. codereview.settings
  31. comments/
  32. contestk/
  33. cq_watcher/
  34. ct/
  35. datahopper/
  36. debugger-app/
  37. demos/
  38. docker/
  39. docker_pushes_watcher/
  40. docs/
  41. docserverk/
  42. dot/
  43. ds/
  44. external/
  45. fiddlek/
  46. firestore/
  47. get_service_account/
  48. git_cookie_authdaemon/
  49. gitsync/
  50. go.mod
  51. go.sum
  52. go/
  53. go_repositories.bzl
  54. gold-client/
  55. golden/
  56. hashtag/
  57. html-template-minifier/
  58. infra-sk/
  59. infra/
  60. jsdoc/
  61. jsfiddle/
  62. k8s-checker/
  63. kube/
  64. launch.md
  65. leasing/
  66. licenses/
  67. machine/
  68. make/
  69. modules/
  70. named-fiddles/
  71. new_element/
  72. package-lock.json
  73. package.json
  74. particles/
  75. perdiff/
  76. perf/
  77. periodic-trigger/
  78. power/
  79. proberk/
  80. promk/
  81. pulld/
  82. puppeteer-tests/
  83. push/
  84. run_unittests
  85. run_unittests.go
  86. scrap/
  87. scripts/
  88. shaders/
  89. sk8s/
  90. skbug/
  91. skfe/
  92. skolo/
  93. skottie/
  94. status/
  95. task_driver/
  96. task_scheduler/
  97. tools.go
  98. tools/
  99. tree_status/
  100. trybot_updater/
  101. tsconfig.json
  102. velero/
  103. whitespace.txt
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \

Get mockery and add it to your PATH.

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small