| commit | adfa63b809436782aeade72828d5b38ffc2098cf | [log] [tgz] |
|---|---|---|
| author | Hao Wu <haowoo@google.com> | Thu Sep 19 21:19:08 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Thu Sep 19 21:28:17 2024 +0000 |
| tree | f7c5b5bffbb445883ce0bb802db6bd123277f71a | |
| parent | 865ffc972867cf10ca77914528597edb48c3e227 [diff] |
Fix the nil pointer when computing range. The chartData is init'd to nil and we need to guard it. Change-Id: I7b0896624028a0fbb7d34a582f66044fb49b6d5b Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/901605 Commit-Queue: Hao Wu <haowoo@google.com> Commit-Queue: Ashwin Verleker <ashwinpv@google.com> Reviewed-by: Ashwin Verleker <ashwinpv@google.com> Auto-Submit: Hao Wu <haowoo@google.com>
diff --git a/perf/modules/plot-summary-sk/plot-summary-sk.ts b/perf/modules/plot-summary-sk/plot-summary-sk.ts index 43a9e36..5b3c361 100644 --- a/perf/modules/plot-summary-sk/plot-summary-sk.ts +++ b/perf/modules/plot-summary-sk/plot-summary-sk.ts
@@ -172,6 +172,10 @@ } private recomputeRange() { + if (!this.currentChartData) { + return; + } + if (this.isCommitScale) { this.commitsStart = this.currentChartData!.start as number; this.commitsEnd = this.currentChartData!.end as number;