| commit | ab60f16e6de0fce4ec1df724dadb35bdfeff4508 | [log] [tgz] |
|---|---|---|
| author | Leandro Lovisolo <lovisolo@google.com> | Thu Jun 17 14:05:15 2021 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Thu Jun 17 18:42:22 2021 +0000 |
| tree | af1859f67eb06667ddae695e51b488643eb3688e | |
| parent | a62f5c24050a9e75d46730137ff4c4be411b8a41 [diff] |
[bazel] Add skia_app_container macro.
This macro provides a convenient way to pack a Bazel-built app inside a Docker container based on gcr.io/skia-public/basealpine. It also generates a target to upload the resulting container to GCR.
Usage (see the skia_app_container docstring for more):
# Built the app container and load it into Docker:
$ bazel run //myapp:myapp_container
# Debug the container:
$ docker run -it --entrypoint /bin/sh bazel/myapp:myapp_container
# Push the container to GCR:
$ bazel run //myapp:push_myapp_container
Today, we build app containers by writing a Dockerfile, and a release.sh script that sources //bash/docker_build.sh to populate the container with any necessary files and upload it to GCR.
This macro is a functionally equivalent, Bazel-native alternative to the Dockerfile + release.sh combo. Its main advantage is that it pulls Bazel-built assets via their Bazel labels, instead of their (often clunky) paths under //_bazel_bin.
Examples showing the two approaches to build the same container:
- Dockerfile + release script: https://skia-review.googlesource.com/c/buildbot/+/418840.
- skia_app_container: https://skia-review.googlesource.com/c/buildbot/+/419137.
Skia Infrastructure engineers are free to use either approach as we migrate our apps to Bazel. That said, this macro can be easily extended to support things like setting environment variables and running arbitrary commands inside the container, which should support virtually all our use cases.
Bug: skia:11111
Change-Id: I25aed677d526828f6d11ea2483969748a1a6205b
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/419136
Reviewed-by: Joe Gregorio <jcgregorio@google.com>
Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.
Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot
Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install python-django $ go get -u github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate
Build ~everything:
$ make all
Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
Get mockery and add it to your PATH.
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small