| commit | 9bc9cc32fe76aee18f49f5d0e31ebeb819475218 | [log] [tgz] |
|---|---|---|
| author | Leina Sun <sunxiaodi@google.com> | Tue Sep 03 17:30:02 2024 +0000 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Tue Sep 03 17:38:46 2024 +0000 |
| tree | 499cd8d3176a600b4abba57a239b40ea9d7231a6 | |
| parent | 438bd94cb3d41aba31f1449d45e30317f1fc7c94 [diff] |
[perf] add extra comment to liveness handler to explain ordering This CL is a follow up to https://skia-review.googlesource.com/c/buildbot/+/895268 Bug: b/361129890 Change-Id: Ide4776625d4f54c85d56d9c58ab634069a36497a Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/895996 Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: Leina Sun <sunxiaodi@google.com> Auto-Submit: Leina Sun <sunxiaodi@google.com>
diff --git a/perf/go/frontend/frontend.go b/perf/go/frontend/frontend.go index 2819040..481ca41 100644 --- a/perf/go/frontend/frontend.go +++ b/perf/go/frontend/frontend.go
@@ -947,6 +947,9 @@ h = httputils.LoggingGzipRequestResponse(h) if !f.flags.Local { h = httputils.HealthzAndHTTPS(h) + // add liveness handler after https routing since these are applied in + // reverse order to ensure k8 pod can access the endpoint without + // 301 moved permanently status h = f.liveness(h) } http.Handle("/", h)