Google Git
Sign in
skia / buildbot / 54fbc846ac58f85eae2f681c194f168b3bebc8a5
commit54fbc846ac58f85eae2f681c194f168b3bebc8a5[log] [tgz]
authorChris Mumford <cmumford@google.com>Thu Sep 21 04:58:56 2023 -0700
committerSkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com>Thu Sep 21 13:07:02 2023 +0000
treede15c331e7abea32c078b829b63c0d571c7e6c38
parent675a0c29da2f14184db43d41b681bafcd555bd7f [diff]
Fix gsutil PATH priority in base-cipd image

Move the ${CIPD_ROOT}/cipd_bin_packages/gsutil directory before
${CIPD_ROOT}/cipd_bin_packages because gsutil (the directory)
contains gsutil (the executable). Otherwise a process may try
to execute the directory (and fail) instead of the executable.

This didn't come up in testing because /bin/sh is smart enough
to skip over the directory, even though it matches first in the
PATH order. It looks like a Go executable is more literal and
tries to run the first match.

Bug: b/295525434
Change-Id: I7bf981213fa9ccc7bad0d68a3d275e2d303687ea
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/758490
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Chris Mumford <cmumford@google.com>
1 file changed
tree: de15c331e7abea32c078b829b63c0d571c7e6c38
  1. am/
  2. android_ingest/
  3. android_stats/
  4. api/
  5. autoroll/
  6. bash/
  7. bazel/
  8. bisection/
  9. blamer/
  10. bugs-central/
  11. cabe/
  12. cd/
  13. cherrypick-watcher/
  14. cmd/
  15. codereview-watcher/
  16. codesize/
  17. comments/
  18. comp-ui/
  19. cq_watcher/
  20. ct/
  21. datahopper/
  22. debugger-app/
  23. demos/
  24. docker/
  25. docker_pushes_watcher/
  26. docs/
  27. docsyserver/
  28. ds/
  29. elements-sk/
  30. email/
  31. external/
  32. fiddlek/
  33. firestore/
  34. get_service_account/
  35. gitsync/
  36. go/
  37. gold-client/
  38. golden/
  39. helloworld/
  40. infra/
  41. infra-sk/
  42. jsdoc/
  43. jsfiddle/
  44. k8s-checker/
  45. k8s-deployer/
  46. kube/
  47. leasing/
  48. licenses/
  49. machine/
  50. make/
  51. modules/
  52. named-fiddles/
  53. new_element/
  54. npm-audit-mirror/
  55. perdiff/
  56. perf/
  57. periodic-trigger/
  58. proberk/
  59. promk/
  60. puppeteer-tests/
  61. sa-keys-checker/
  62. scrap/
  63. scripts/
  64. shaders/
  65. sk/
  66. skbug/
  67. skcq/
  68. skfe/
  69. skolo/
  70. skottie/
  71. static_server/
  72. status/
  73. task_driver/
  74. task_scheduler/
  75. test-service/
  76. tools/
  77. tree_status/
  78. trybot_updater/
  79. .bazelignore
  80. .bazelrc
  81. .bazelversion
  82. .eslintrc.js
  83. .gitattributes
  84. .gitignore
  85. .npmrc
  86. .prettierignore
  87. .prettierrc.json
  88. .puppeteerrc.js
  89. .vpython
  90. BAZEL_CHEATSHEET.md
  91. BUILD.bazel
  92. build_infra_prod.sh
  93. cipd.ensure
  94. codereview.settings
  95. DATASTORE.md
  96. demopage.sh
  97. DEPS
  98. go.mod
  99. go.sum
  100. go_repositories.bzl
  101. karmatest.sh
  102. launch.md
  103. LICENSE
  104. Makefile
  105. OWNERS
  106. package-lock.json
  107. package.json
  108. PRESUBMIT.py
  109. PRIVACY_POLICY.md
  110. README.md
  111. STYLEGUIDE.md
  112. tools.go
  113. tsconfig.json
  114. whitespace.txt
  115. WORKSPACE
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Install dependencies

Almost all applications are built with Bazel, and bazelisk is the recommended tool to ensure you have the right version of bazel installed:

go install github.com/bazelbuild/bazelisk@latest
go install github.com/bazelbuild/buildtools/buildifier@latest
go install github.com/kisielk/errcheck@latest
go install golang.org/x/tools/cmd/goimports@latest
go install github.com/mikefarah/yq/v4@latest
go install go.chromium.org/luci/client/cmd/...@latest

Install other dependencies:

sudo apt-get install jq

Build ~everything

bazelisk build --config=mayberemote //...

Test everything

bazelisk test --config=mayberemote //...

Generated Code

To update generated code run the following in any directory:

go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

./run_unittests --small