commit | 7f5a92b5d8e69bf4d7434660888b8a93ee1b665e | [log] [tgz] |
---|---|---|
author | Leandro Lovisolo <lovisolo@google.com> | Tue Jan 24 22:11:08 2023 +0000 |
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Wed Jan 25 01:13:42 2023 +0000 |
tree | 611e28b9f0ed7349e259741c9b7294b75af77c21 | |
parent | 90df4e83667f8ef4e672e3c3e85d2a5c465c7616 [diff] |
[gold] /json/v2/expectations RPC: Log baseline size and whether it was cached. The Chrome folks have observed that sometimes goldctl falsely reports that a digest is untriaged. For example, in this task[1] goldctl reports: warning: got empty expectations when querying https://chrome-gold.skia.org/json/v2/expectations?issue=4075226&crs=gerrit However, the baseline is not empty. This CL adds some extra information to the "fetchBaseline" trace, which should help determine the cause of this issue. [1] https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-rel/1403643/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2Fash%3Aash_pixeltests%2FAppListItemViewPixelTest.AppListItemView%2FAll.4+VHash%3A4a9dc8330285b99c Bug: skia:13980 Change-Id: If0af056a90d4b738b81d14ac4f3b4e3c0ebbbec8 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/633507 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
This repo contains infrastructure code for Skia.
The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone
or via go get
.
Using git clone
allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:
$ cd ${WORKDIR} $ git clone https://skia.googlesource.com/buildbot.git $ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR}) $ mkdir $GOPATH $ cd buildbot
Using go get
will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:
$ export GOPATH=${WORKDIR} $ export GO111MODULE=on $ go get -u -t go.skia.org/infra/... $ cd ${GOPATH}/src/go.skia.org/infra/
Note: go.skia.org is a custom import path and will only work if used like the examples here.
Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g
, as suggested by the npm getting started doc.
Install other dependencies:
$ sudo apt-get install \ jq \ python-django $ go get -u \ github.com/kisielk/errcheck \ golang.org/x/tools/cmd/goimports \ go.chromium.org/luci/client/cmd/isolate \ go get github.com/mikefarah/yq/v4
Build ~everything:
$ make all
Some code is generated using go generate
with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.
Install the necessary go packages:
$ go get -u \ github.com/golang/protobuf/protoc-gen-go \ golang.org/x/tools/cmd/stringer \ google.golang.org/grpc \
To generate code run in this directory:
$ go generate ./...
Install Cloud SDK.
Use this command to run the presubmit tests:
$ ./run_unittests --small