Google Git
Sign in
skia / buildbot / 807aa31eff5e520e807bd4ad476aa544919d8eeb
commit807aa31eff5e520e807bd4ad476aa544919d8eeb[log] [tgz]
authorJoe Gregorio <jcgregorio@google.com>Wed Jul 22 19:40:57 2020 -0400
committerSkia Commit-Bot <skia-commit-bot@chromium.org>Thu Jul 23 14:20:05 2020 +0000
tree419d8a7bd69bf67e6fe26c972e5677dd62519853
parent263a877b2b18ce1749ab9eb3bfb482c71cd5dd59 [diff]
[perf] Remove all vestiges of sqlite3.

Given the changes need to make the SQL backed engine performant
carrying a second SQL implementation will be needlessly difficult.

For example, to do batch inserts of trace values we need to build
the insert command on the fly since the Golang database/sql module
doesn't support batches. Doing that same work for sqlite3 just
doubles the work for no perceived benefit.

Change-Id: I53d61fb448f71c3a3c92163fe094a1e22f10fc75
Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/305236
Reviewed-by: Kevin Lubick <kjlubick@google.com>
Commit-Queue: Joe Gregorio <jcgregorio@google.com>
28 files changed
tree: 419d8a7bd69bf67e6fe26c972e5677dd62519853
  1. am/
  2. android_compile/
  3. android_ingest/
  4. android_stats/
  5. api/
  6. autoroll/
  7. bash/
  8. blamer/
  9. chromeextensions/
  10. comments/
  11. contestk/
  12. cq_watcher/
  13. ct/
  14. datahopper/
  15. debugger/
  16. debugger-assets/
  17. demos/
  18. docker/
  19. docker_pushes_watcher/
  20. docs/
  21. docserverk/
  22. dot/
  23. ds/
  24. fiddlek/
  25. firestore/
  26. get_service_account/
  27. git_cookie_authdaemon/
  28. gitsync/
  29. go/
  30. gold-client/
  31. golden/
  32. hashtag/
  33. html-template-minifier/
  34. infra/
  35. infra-sk/
  36. jsdoc/
  37. jsfiddle/
  38. k8s-checker/
  39. kube/
  40. leasing/
  41. licenses/
  42. machine/
  43. make/
  44. named-fiddles/
  45. particles/
  46. perdiff/
  47. perf/
  48. periodic-trigger/
  49. power/
  50. proberk/
  51. promk/
  52. pulld/
  53. puppeteer-tests/
  54. push/
  55. res/
  56. scripts/
  57. sheriff_emails/
  58. sk8s/
  59. skbug/
  60. skfe/
  61. skolo/
  62. skottie/
  63. status/
  64. task_driver/
  65. task_scheduler/
  66. tools/
  67. tree_status/
  68. trybot_updater/
  69. velero/
  70. webtools/
  71. .eslintrc.js
  72. .gitattributes
  73. .gitignore
  74. .mocharc.json
  75. build_infra_prod.sh
  76. cipd.ensure
  77. codereview.settings
  78. DATASTORE.md
  79. DEPS
  80. go.mod
  81. go.sum
  82. launch.md
  83. LICENSE
  84. Makefile
  85. package-lock.json
  86. package.json
  87. PRESUBMIT.py
  88. PRIVACY_POLICY.md
  89. README.md
  90. run_unittests
  91. run_unittests.go
  92. STYLEGUIDE.md
  93. tools.go
  94. whitespace.txt
README.md

Skia-Buildbot Repository

This repo contains infrastructure code for Skia.

Getting the Source Code

The main source code repository is a Git repository hosted at https://skia.googlesource.com/buildbot.git. It is possible to check out this repository directly with git clone or via go get.

Using git clone allows you to work in whatever directory you want. You will still need to set GOPATH in order to build some apps (recommended to put this in a cache dir). E.g.:

$ cd ${WORKDIR}
$ git clone https://skia.googlesource.com/buildbot.git
$ export GOPATH=${HOME}/.cache/gopath/$(basename ${WORKDIR})
$ mkdir $GOPATH
$ cd buildbot

Using go get will fetch the repository into your GOPATH directory along with all the Go dependencies. You will need to set GOPATH and GO111MODULE=on. E.g.:

$ export GOPATH=${WORKDIR}
$ export GO111MODULE=on
$ go get -u -t go.skia.org/infra/...
$ cd ${GOPATH}/src/go.skia.org/infra/

Note: go.skia.org is a custom import path and will only work if used like the examples here.

Install Node.js (not as root) and add the bin dir to your path. Optionally run npm install npm -g, as suggested by the npm getting started doc.

Install other dependencies:

$ sudo apt-get install python-django
$ go get -u github.com/kisielk/errcheck \
  golang.org/x/tools/cmd/goimports \
  go.chromium.org/luci/client/cmd/isolate
$ npm install -g polylint bower

Build ~everything:

$ make all

Generated Code

Some code is generated using go generate with external binaries. First, install the version of protoc referenced in the asset creation script and ensure it is on your PATH before other versions of protoc.

Install the necessary go packages:

$ go get -u \
  github.com/golang/protobuf/protoc-gen-go \
  golang.org/x/tools/cmd/stringer \
  google.golang.org/grpc \
  github.com/vektra/mockery/...

To generate code run in this directory:

$ go generate ./...

Running unit tests

Install Cloud SDK.

Use this command to run the presubmit tests:

$ ./run_unittests --small